Reverse true/false clause in setColumnReadOnly; it was implemented reversed in r8406. This fix prevents modification of the id column.

telwertowski · telwertowski · commit c7a9460bc6d3 · 2008-07-07T02:25:54.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@8719 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgsattributetable.cpp b/src/app/qgsattributetable.cpp
@@ -97,7 +97,7 @@ void QgsAttributeTable::setColumnReadOnly(int col, bool ro)
   for (int i = 0; i < rowCount(); ++i)
   {
   	QTableWidgetItem *item = this->item(i, col);
-    item->setFlags(ro ? item->flags() | Qt::ItemIsEditable : item->flags() & ~Qt::ItemIsEditable);
+    item->setFlags(ro ? item->flags() & ~Qt::ItemIsEditable : item->flags() | Qt::ItemIsEditable);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ void QgsAttributeTable::setColumnReadOnly(int col, bool ro)`
`97`	`97`	`for (int i = 0; i < rowCount(); ++i)`
`98`	`98`	`{`
`99`	`99`	`QTableWidgetItem *item = this->item(i, col);`
`100`		`- item->setFlags(ro ? item->flags() \| Qt::ItemIsEditable : item->flags() & ~Qt::ItemIsEditable);`
	`100`	`+ item->setFlags(ro ? item->flags() & ~Qt::ItemIsEditable : item->flags() \| Qt::ItemIsEditable);`
`101`	`101`	`}`
`102`	`102`	`}`
`103`	`103`