Skip to content

Commit

Permalink
[needs-docs] Reword "delete" option in db connection dialog
Browse files Browse the repository at this point in the history 
Button has been changed to "remove", to make it clear that
the button just removes the connection, it does not delete
the database! (It was confusing for spatialite dbs)

Also add tooltips to buttons for extra clarification.
  • Loading branch information
@nyalldawson
nyalldawson committed May 29, 2016
1 parent e2abea6 commit c7a4e5a
Showing 1 changed file with 24 additions and 4 deletions.
28 changes: 24 additions & 4 deletions src/ui/qgsdbsourceselectbase.ui
View file
Expand Up @@ -15,8 +15,7 @@
</property>
<property name="windowIcon">
<iconset>
<normaloff/>
</iconset>
<normaloff>.</normaloff>.</iconset>
</property>
<property name="sizeGripEnabled">
<bool>true</bool>
Expand All @@ -38,29 +37,41 @@
<layout class="QHBoxLayout" name="horizontalLayout">
<item>
<widget class="QPushButton" name="btnConnect">
<property name="toolTip">
<string>Connect to selected database</string>
</property>
<property name="text">
<string>Connect</string>
</property>
</widget>
</item>
<item>
<widget class="QPushButton" name="btnNew">
<property name="toolTip">
<string>Create a new database connection</string>
</property>
<property name="text">
<string>New</string>
</property>
</widget>
</item>
<item>
<widget class="QPushButton" name="btnEdit">
<property name="toolTip">
<string>Edit selected database connection</string>
</property>
<property name="text">
<string>Edit</string>
</property>
</widget>
</item>
<item>
<widget class="QPushButton" name="btnDelete">
<property name="toolTip">
<string>Remove connection to selected database</string>
</property>
<property name="text">
<string>Delete</string>
<string>Remove</string>
</property>
</widget>
</item>
Expand Down Expand Up @@ -158,7 +169,16 @@
<bool>false</bool>
</property>
<layout class="QGridLayout">
<property name="margin">
<property name="leftMargin">
<number>9</number>
</property>
<property name="topMargin">
<number>9</number>
</property>
<property name="rightMargin">
<number>9</number>
</property>
<property name="bottomMargin">
<number>9</number>
</property>
<property name="spacing">
Expand Down

1 comment on commit c7a4e5a

@nirvn
Copy link
Contributor

@nirvn nirvn commented on c7a4e5a May 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson , brilliant; after all these years, I would still get worried for a second when reading [ DELETE ].

Please sign in to comment.