Disable "Change data source..." action if layer is editable

qgis · Nov 8, 2018 · c74ce88 · c74ce88
1 parent 85f8ba3
commit c74ce88
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/app/qgsapplayertreeviewmenuprovider.cpp b/src/app/qgsapplayertreeviewmenuprovider.cpp
@@ -200,15 +200,23 @@ QMenu *QgsAppLayerTreeViewMenuProvider::createContextMenu()
       menu->addSeparator();
 
       // change data source is only supported for vectors and rasters
-      if ( vlayer || rlayer )
+      if ( ( vlayer || rlayer ) )
       {
 
         QAction *a = new QAction( tr( "Change data source…" ), menu );
-        connect( a, &QAction::triggered, [ = ]
+        if ( layer->isEditable() )
         {
-          QgisApp::instance()->changeDataSource( layer );
-        } );
+          a->setEnabled( false );
+        }
+        else
+        {
+          connect( a, &QAction::triggered, [ = ]
+          {
+            QgisApp::instance()->changeDataSource( layer );
+          } );
+        }
         menu->addAction( a );
+        // Disable when layer is editable
       }
 
       if ( vlayer )

diff --git a/tests/testdata/projects/bad_layers_test.gpkg b/tests/testdata/projects/bad_layers_test.gpkg