Skip to content

Commit c69c596

Browse files
committedJun 17, 2017
New style signal/slot connections
1 parent 8bfbe19 commit c69c596

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed
 

‎src/core/auth/qgsauthmanager.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2911,7 +2911,7 @@ bool QgsAuthManager::passwordHelperDelete()
29112911
job.setAutoDelete( false );
29122912
job.setKey( AUTH_PASSWORD_HELPER_KEY_NAME );
29132913
QEventLoop loop;
2914-
job.connect( &job, SIGNAL( finished( QKeychain::Job * ) ), &loop, SLOT( quit() ) );
2914+
connect( &job, &QKeychain::Job::finished, &loop, &QEventLoop::quit );
29152915
job.start();
29162916
loop.exec();
29172917
if ( job.error() )
@@ -2943,7 +2943,7 @@ QString QgsAuthManager::passwordHelperRead()
29432943
job.setAutoDelete( false );
29442944
job.setKey( AUTH_PASSWORD_HELPER_KEY_NAME );
29452945
QEventLoop loop;
2946-
job.connect( &job, SIGNAL( finished( QKeychain::Job * ) ), &loop, SLOT( quit() ) );
2946+
connect( &job, &QKeychain::Job::finished, &loop, &QEventLoop::quit );
29472947
job.start();
29482948
loop.exec();
29492949
if ( job.error() )
@@ -2986,7 +2986,7 @@ bool QgsAuthManager::passwordHelperWrite( const QString &password )
29862986
job.setKey( AUTH_PASSWORD_HELPER_KEY_NAME );
29872987
job.setTextData( password );
29882988
QEventLoop loop;
2989-
job.connect( &job, SIGNAL( finished( QKeychain::Job * ) ), &loop, SLOT( quit() ) );
2989+
connect( &job, &QKeychain::Job::finished, &loop, &QEventLoop::quit );
29902990
job.start();
29912991
loop.exec();
29922992
if ( job.error() )

‎src/gui/qgsadvanceddigitizingdockwidget.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,10 @@ QgsAdvancedDigitizingDockWidget::QgsAdvancedDigitizingDockWidget( QgsMapCanvas *
140140
connect( mRepeatingLockAngleButton, &QAbstractButton::clicked, this, &QgsAdvancedDigitizingDockWidget::setConstraintRepeatingLock );
141141
connect( mRepeatingLockXButton, &QAbstractButton::clicked, this, &QgsAdvancedDigitizingDockWidget::setConstraintRepeatingLock );
142142
connect( mRepeatingLockYButton, &QAbstractButton::clicked, this, &QgsAdvancedDigitizingDockWidget::setConstraintRepeatingLock );
143-
connect( mAngleLineEdit, SIGNAL( returnPressed() ), this, SLOT( lockConstraint() ) );
144-
connect( mDistanceLineEdit, SIGNAL( returnPressed() ), this, SLOT( lockConstraint() ) );
145-
connect( mXLineEdit, SIGNAL( returnPressed() ), this, SLOT( lockConstraint() ) );
146-
connect( mYLineEdit, SIGNAL( returnPressed() ), this, SLOT( lockConstraint() ) );
143+
connect( mAngleLineEdit, &QLineEdit::returnPressed, this, [ = ]() { lockConstraint(); } );
144+
connect( mDistanceLineEdit, &QLineEdit::returnPressed, this, [ = ]() { lockConstraint(); } );
145+
connect( mXLineEdit, &QLineEdit::returnPressed, this, [ = ]() { lockConstraint(); } );
146+
connect( mYLineEdit, &QLineEdit::returnPressed, this, [ = ]() { lockConstraint(); } );
147147
connect( mAngleLineEdit, &QLineEdit::textEdited, this, &QgsAdvancedDigitizingDockWidget::constraintTextEdited );
148148
connect( mDistanceLineEdit, &QLineEdit::textEdited, this, &QgsAdvancedDigitizingDockWidget::constraintTextEdited );
149149
connect( mXLineEdit, &QLineEdit::textEdited, this, &QgsAdvancedDigitizingDockWidget::constraintTextEdited );
@@ -275,7 +275,6 @@ void QgsAdvancedDigitizingDockWidget::additionalConstraintClicked( bool activate
275275
}
276276
}
277277

278-
279278
void QgsAdvancedDigitizingDockWidget::setConstraintRelative( bool activate )
280279
{
281280
if ( sender() == mRelativeAngleButton )

‎src/gui/qgsmaptip.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ void QgsMapTip::showMapTip( QgsMapLayer *pLayer,
6666
#if WITH_QTWEBKIT
6767
mWebView->page()->setLinkDelegationPolicy( QWebPage::DelegateAllLinks );//Handle link clicks by yourself
6868
mWebView->setContextMenuPolicy( Qt::NoContextMenu ); //No context menu is allowed if you don't need it
69-
connect( mWebView, SIGNAL( linkClicked( QUrl ) ), this, SLOT( onLinkClicked( QUrl ) ) );
69+
connect( mWebView, &QWebView::linkClicked, this, &QgsMapTip::onLinkClicked );
7070
#endif
7171

7272
mWebView->page()->settings()->setAttribute(

0 commit comments

Comments
 (0)