Don't use combobox of existing composer names in new composer title dialog

nyalldawson · nyalldawson · commit c66026886ec7 · 2017-03-21T10:32:53.000+10:00
It's odd UX - selecting any of these results in an error message, so giving them as choices is misleading. Fix #12673 (indirectly)
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -6936,12 +6936,11 @@ bool QgisApp::uniqueComposerTitle( QWidget *parent, QString &composerTitle, bool
 
   while ( !titleValid )
   {
-    newTitle = QInputDialog::getItem( parent,
+    newTitle = QInputDialog::getText( parent,
                                       tr( "Composer title" ),
                                       titleMsg,
-                                      cNames,
-                                      cNames.indexOf( newTitle ),
-                                      true,
+                                      QLineEdit::Normal,
+                                      newTitle,
                                       &ok );
     if ( !ok )
     {
