[processing] Correctly handle layer type parameter values when

nyalldawson · nyalldawson · commit c65afbdd9794 · 2018-07-19T07:22:06.000+10:00
creating an algorithm dialog using processing.execAlgorithmDialog()
diff --git a/python/plugins/processing/gui/wrappers.py b/python/plugins/processing/gui/wrappers.py
@@ -908,13 +908,24 @@ def setValue(self, value):
             return
 
         if self.dialogType == DIALOG_STANDARD:
-            if self.combo.findText(value) >= 0:
-                self.combo.setCurrentIndex(self.combo.findText(value))
-            else:
-                items = self.combo.additionalItems()
-                items.append(value)
-                self.combo.setAdditionalItems(items)
-                self.combo.setCurrentIndex(self.combo.findText(value))
+            if isinstance(value, str):
+                layer = QgsProject.instance().mapLayer(value)
+                if layer is not None:
+                    value = layer
+
+            found = False
+            if isinstance(value, QgsMapLayer):
+                self.combo.setLayer(value)
+                found = self.combo.currentIndex() != -1
+
+            if not found:
+                if self.combo.findText(value) >= 0:
+                    self.combo.setCurrentIndex(self.combo.findText(value))
+                else:
+                    items = self.combo.additionalItems()
+                    items.append(value)
+                    self.combo.setAdditionalItems(items)
+                    self.combo.setCurrentIndex(self.combo.findText(value))
         elif self.dialogType == DIALOG_BATCH:
             self.widget.setValue(value)
         else:
@@ -1146,13 +1157,24 @@ def setValue(self, value):
             return
 
         if self.dialogType == DIALOG_STANDARD:
-            if self.combo.findText(value) >= 0:
-                self.combo.setCurrentIndex(self.combo.findText(value))
-            else:
-                items = self.combo.additionalItems()
-                items.append(value)
-                self.combo.setAdditionalItems(items)
-                self.combo.setCurrentIndex(self.combo.findText(value))
+            if isinstance(value, str):
+                layer = QgsProject.instance().mapLayer(value)
+                if layer is not None:
+                    value = layer
+
+            found = False
+            if isinstance(value, QgsMapLayer):
+                self.combo.setLayer(value)
+                found = self.combo.currentIndex() != -1
+
+            if not found:
+                if self.combo.findText(value) >= 0:
+                    self.combo.setCurrentIndex(self.combo.findText(value))
+                else:
+                    items = self.combo.additionalItems()
+                    items.append(value)
+                    self.combo.setAdditionalItems(items)
+                    self.combo.setCurrentIndex(self.combo.findText(value))
         elif self.dialogType == DIALOG_BATCH:
             self.widget.setValue(value)
         else:
@@ -1448,13 +1470,24 @@ def setValue(self, value):
             return
 
         if self.dialogType == DIALOG_STANDARD:
-            if self.combo.findText(value) >= 0:
-                self.combo.setCurrentIndex(self.combo.findText(value))
-            else:
-                items = self.combo.additionalItems()
-                items.append(value)
-                self.combo.setAdditionalItems(items)
-                self.combo.setCurrentIndex(self.combo.findText(value))
+            if isinstance(value, str):
+                layer = QgsProject.instance().mapLayer(value)
+                if layer is not None:
+                    value = layer
+
+            found = False
+            if isinstance(value, QgsMapLayer):
+                self.combo.setLayer(value)
+                found = self.combo.currentIndex() != -1
+
+            if not found:
+                if self.combo.findText(value) >= 0:
+                    self.combo.setCurrentIndex(self.combo.findText(value))
+                else:
+                    items = self.combo.additionalItems()
+                    items.append(value)
+                    self.combo.setAdditionalItems(items)
+                    self.combo.setCurrentIndex(self.combo.findText(value))
         elif self.dialogType == DIALOG_BATCH:
             return self.widget.setValue(value)
         else:
