Don't use an event loop to wait for task starting

nyalldawson · rldhont · commit c52a0ba62c7d · 2020-05-21T20:14:18.000+02:00
This is already handled in a MUCH nicer way by QgsTask::waitForFinished
(mutex based, not eventloop based)
diff --git a/src/core/qgsabstractcontentcache.h b/src/core/qgsabstractcontentcache.h
@@ -458,15 +458,6 @@ class CORE_EXPORT QgsAbstractContentCache : public QgsAbstractContentCacheBase
      */
     bool waitForTaskFinished( QgsNetworkContentFetcherTask *task ) const
     {
-      // First step, waiting for task running
-      if ( task->status() != QgsTask::Running )
-      {
-        QEventLoop loop;
-        connect( task, &QgsNetworkContentFetcherTask::begun, &loop, &QEventLoop::quit );
-        if ( task->status() != QgsTask::Running )
-          loop.exec();
-      }
-
       // Second step, wait 5 seconds for task finished
       if ( task->waitForFinished( 5000 ) )
       {
