Skip to content

Commit c49b5b7

Browse files
committedOct 7, 2015
Change a lot of arguments to const references in core/gui
Rationale: - there was a lot of large objects passed by value, so potentially there's a speed bump from this - even for implicitly shared classes like QString/QList there's still a (small) cost for copying the objects when there's no reason to - it's the right thing to do!
1 parent 33265e2 commit c49b5b7

File tree

721 files changed

+2288
-2291
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

721 files changed

+2288
-2291
lines changed
 

‎python/analysis/interpolation/qgsgridfilewriter.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ class QgsGridFileWriter
55
%End
66

77
public:
8-
QgsGridFileWriter( QgsInterpolator* i, QString outputPath, QgsRectangle extent, int nCols, int nRows, double cellSizeX, double cellSizeY );
8+
QgsGridFileWriter( QgsInterpolator* i, const QString& outputPath, const QgsRectangle& extent, int nCols, int nRows, double cellSizeX, double cellSizeY );
99
~QgsGridFileWriter();
1010

1111
/** Writes the grid file.

‎python/analysis/vector/qgspointsample.sip

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class QgsPointSample
77
#include <qgspointsample.h>
88
%End
99
public:
10-
QgsPointSample( QgsVectorLayer* inputLayer, const QString& outputLayer, QString nPointsAttribute, QString minDistAttribute = QString() );
10+
QgsPointSample( QgsVectorLayer* inputLayer, const QString& outputLayer, const QString& nPointsAttribute, const QString& minDistAttribute = QString() );
1111
~QgsPointSample();
1212

1313
/** Starts calculation of random points

0 commit comments

Comments
 (0)
Please sign in to comment.