Fix uninitialized member (thanks to Coverity)

nyalldawson · nyalldawson · commit c404b8020af3 · 2017-07-17T13:00:28.000+10:00
diff --git a/src/core/qgsvectorlayerjoininfo.h b/src/core/qgsvectorlayerjoininfo.h
@@ -33,10 +33,7 @@
 class CORE_EXPORT QgsVectorLayerJoinInfo
 {
   public:
-    QgsVectorLayerJoinInfo()
-      : mMemoryCache( false )
-      , cacheDirty( true )
-    {}
+    QgsVectorLayerJoinInfo() = default;
 
     //! Sets weak reference to the joined layer
     void setJoinLayer( QgsVectorLayer *layer ) { mJoinLayerRef = QgsVectorLayerRef( layer ); }
@@ -119,7 +116,7 @@ class CORE_EXPORT QgsVectorLayerJoinInfo
     QString mPrefix;
 
     //! True if the join is cached in virtual memory
-    bool mMemoryCache;
+    bool mMemoryCache = false;
 
     //! Subset of fields to use from joined layer. null = use all fields
     std::shared_ptr<QStringList> mJoinFieldsSubset;
@@ -130,9 +127,9 @@ class CORE_EXPORT QgsVectorLayerJoinInfo
     friend class QgsVectorLayerFeatureIterator;
 
     //! True if the cached join attributes need to be updated
-    bool cacheDirty;
+    bool cacheDirty = true;
 
-    bool mDynamicForm;
+    bool mDynamicForm = false;
 
     //! Cache for joined attributes to provide fast lookup (size is 0 if no memory caching)
     QHash< QString, QgsAttributes> cachedAttributes;
