Followups

nyalldawson · nyalldawson · commit c3b69900f782 · 2018-04-26T19:01:50.000+10:00
diff --git a/src/providers/oracle/qgsoracleprovider.cpp b/src/providers/oracle/qgsoracleprovider.cpp
@@ -1301,7 +1301,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag
         QVariant value = attributevec.value( fieldId[i], QVariant() );
 
         QString v;
-        if ( !value.isValid() || value.isNull() )
+        if ( value.isNull() )
         {
           if ( mPrimaryKeyAttrs.contains( i ) && !defaultValues.at( i ).isEmpty() )
           {
diff --git a/tests/src/python/test_provider_oracle.py b/tests/src/python/test_provider_oracle.py
@@ -63,7 +63,6 @@ def execSQLCommand(self, sql, ignore_errors=False):
         self.assertTrue(query.exec_(sql), sql + ': ' + query.lastError().text())
         query.finish()
 
-    # disabled: WIP
     def getSource(self):
         # create temporary table for edit tests
         self.execSQLCommand('DROP TABLE "QGIS"."EDIT_DATA"', ignore_errors=True)
@@ -79,7 +78,6 @@ def getSource(self):
             'test', 'oracle')
         return vl
 
-    # disabled: WIP
     def getEditableLayer(self):
         return self.getSource()
 

Original file line number	Diff line number	Diff line change
`@@ -1301,7 +1301,7 @@ bool QgsOracleProvider::addFeatures( QgsFeatureList &flist, QgsFeatureSink::Flag`
`1301`	`1301`	`QVariant value = attributevec.value( fieldId[i], QVariant() );`
`1302`	`1302`
`1303`	`1303`	`QString v;`
`1304`		`- if ( !value.isValid() \|\| value.isNull() )`
	`1304`	`+ if ( value.isNull() )`
`1305`	`1305`	`{`
`1306`	`1306`	`if ( mPrimaryKeyAttrs.contains( i ) && !defaultValues.at( i ).isEmpty() )`
`1307`	`1307`	`{`