Cleanup and clarify use of QgsGeorefDataPoint copy constructor

nyalldawson · nyalldawson · commit c2cef74d5651 · 2023-04-17T16:01:29.000+10:00
diff --git a/src/app/georeferencer/qgsgeorefdatapoint.cpp b/src/app/georeferencer/qgsgeorefdatapoint.cpp
@@ -35,15 +35,20 @@ QgsGeorefDataPoint::QgsGeorefDataPoint( QgsMapCanvas *srcCanvas, QgsMapCanvas *d
   mGCPDestinationItem->show();
 }
 
+// NOTE: copy constructor is only used to copy data points for the QgsResidualPlotItem layout item.
+// Accordingly only some members are copied. Ideally things like the id and residual could be moved
+// to another class (QgsGcpPoint?) so that QgsGeorefDataPoint can become a canvas associated GUI only
+// class.
 QgsGeorefDataPoint::QgsGeorefDataPoint( const QgsGeorefDataPoint &p )
   : QObject( nullptr )
+  , mSrcCanvas( p.mSrcCanvas )
+  , mDstCanvas( p.mDstCanvas )
+  , mGCPSourceItem( nullptr )
+  , mGCPDestinationItem( nullptr )
   , mGcpPoint( p.mGcpPoint )
+  , mId( p.id() )
+  , mResidual( p.residual() )
 {
-  // we share item representation on canvas between all points
-//  mGCPSourceItem = new QgsGCPCanvasItem(p.srcCanvas(), p.pixelCoords(), p.mapCoords(), p.isEnabled());
-//  mGCPDestinationItem = new QgsGCPCanvasItem(p.dstCanvas(), p.pixelCoords(), p.mapCoords(), p.isEnabled());
-  mResidual = p.residual();
-  mId = p.id();
 }
 
 QgsGeorefDataPoint::~QgsGeorefDataPoint()
