Skip to content

Commit c295c92

Browse files
committedOct 18, 2017
Remove empty item from plugin manager tabs
1 parent 5a14a92 commit c295c92

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed
 

‎src/ui/qgspluginmanagerbase.ui

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -188,18 +188,6 @@
188188
<set>ItemIsSelectable|ItemIsEnabled</set>
189189
</property>
190190
</item>
191-
<item>
192-
<property name="text">
193-
<string/>
194-
</property>
195-
<property name="icon">
196-
<iconset resource="../../images/images.qrc">
197-
<normaloff>:/images/themes/default/propertyicons/spacer.svg</normaloff>:/images/themes/default/propertyicons/spacer.svg</iconset>
198-
</property>
199-
<property name="flags">
200-
<set>NoItemFlags</set>
201-
</property>
202-
</item>
203191
<item>
204192
<property name="text">
205193
<string>Install from ZIP</string>

3 commit comments

Comments
 (3)

rduivenvoorde commented on Oct 18, 2017

@rduivenvoorde
Contributor

@nyalldawson @borysiasty removing this breaks tab behaviour: it does not show the right tabs anymore now :-(

rduivenvoorde commented on Oct 19, 2017

@rduivenvoorde
Contributor

@nyalldawson @borysiasty currently you cannot see the plugin manager settings...

And I'm not able to use the 'install from zip' here on a windows machine today's master.
I downloaded the plugin zip:
http://plugins.qgis.org/plugins/pdokservicesplugin/version/0.14/download/
or (experimental should be enabled):
http://plugins.qgis.org/plugins/pdoklocator/version/0.1/download/

All seems fine, but after clicking the 'Install plugin' nothing happens, no apparent install, and no error?

OR is it related to this tabs being wrong?

borysiasty commented on Oct 19, 2017

@borysiasty
Member

@rduivenvoorde - yes, removing the spacer item changed the tab numbers, so you just need to click "Settings" in order to get the "Install from zip" :) And "Settings" are currently not available.

@nyalldawson - what do you propose instead of the spacer? Let's discuss it in qgis/qgis3_UIX_discussion#24

Please sign in to comment.