Protect against centroid failures

qgis · Jun 28, 2018 · c20717a · c20717a
1 parent ce541cb
commit c20717a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/analysis/processing/qgsalgorithmkmeansclustering.cpp b/src/analysis/processing/qgsalgorithmkmeansclustering.cpp
@@ -109,17 +109,20 @@ QVariantMap QgsKMeansClusteringAlgorithm::processAlgorithm( const QVariantMap &p
     if ( !feat.hasGeometry() )
       continue;
 
-    n++;
-
     QgsPointXY point;
     if ( QgsWkbTypes::flatType( feat.geometry().wkbType() ) == QgsWkbTypes::Point )
       point = QgsPointXY( *qgsgeometry_cast< const QgsPoint * >( feat.geometry().constGet() ) );
     else
     {
       QgsGeometry centroid = feat.geometry().centroid();
+      if ( !centroid )
+        continue; // centroid failed, e.g. empty linestring
+
       point = QgsPointXY( *qgsgeometry_cast< const QgsPoint * >( centroid.constGet() ) );
     }
 
+    n++;
+
     idToObj.insert( feat.id(), clusterFeatures.size() );
     clusterFeatures.emplace_back( Feature( point ) );
   }