Safer filtering step thanks to QgsExpression

pblottiere · pblottiere · commit c09f5bef8370 · 2017-06-30T08:24:26.000+01:00
diff --git a/src/core/qgsvectorlayerjoinbuffer.cpp b/src/core/qgsvectorlayerjoinbuffer.cpp
@@ -419,7 +419,9 @@ QgsFeature QgsVectorLayerJoinBuffer::joinedFeatureOf( const QgsVectorLayerJoinIn
   if ( info.joinLayer() )
   {
     const QVariant targetValue = feature.attribute( info.targetFieldName() );
-    const QString filter = QString( "\"%1\" = %2" ).arg( info.joinFieldName(), targetValue.toString() );
+    QString fieldRef = QgsExpression::quotedColumnRef( info.joinFieldName() );
+    QString quotedVal = QgsExpression::quotedValue( targetValue.toString() );
+    const QString filter = QString( "%1 = %2" ).arg( fieldRef, quotedVal );
 
     QgsFeatureRequest request;
     request.setFilterExpression( filter );
