Use more efficient string functions

mhugent · nyalldawson · commit c02630b77007 · 2018-08-10T10:01:32.000+10:00
diff --git a/src/app/qgsclipboard.cpp b/src/app/qgsclipboard.cpp
@@ -261,20 +261,20 @@ QgsFields QgsClipboard::retrieveFields() const
     }
 
     //wkt?
-    QStringList lines = string.split( "\n" );
-    if ( lines.size() > 0 )
+    QStringList lines = string.split( '\n' );
+    if ( !lines.empty() )
     {
-      QStringList fieldNames = lines.at( 0 ).split( "\t" );
+      QStringList fieldNames = lines.at( 0 ).split( '\t' );
       //wkt / text always has wkt_geom as first attribute (however values can be NULL)
-      if ( fieldNames.at( 0 ) != "wkt_geom" )
+      if ( fieldNames.at( 0 ) != QLatin1String( "wkt_geom" ) )
       {
         return f;
       }
 
       for ( int i = 0; i < fieldNames.size(); ++i )
       {
         QString fieldName = fieldNames.at( i );
-        if ( fieldName == "wkt_geom" )
+        if ( fieldName == QLatin1String( "wkt_geom" ) )
         {
           continue;
         }

Original file line number	Diff line number	Diff line change
`@@ -261,20 +261,20 @@ QgsFields QgsClipboard::retrieveFields() const`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`//wkt?`
`264`		`- QStringList lines = string.split( "\n" );`
`265`		`- if ( lines.size() > 0 )`
	`264`	`+ QStringList lines = string.split( '\n' );`
	`265`	`+ if ( !lines.empty() )`
`266`	`266`	`{`
`267`		`- QStringList fieldNames = lines.at( 0 ).split( "\t" );`
	`267`	`+ QStringList fieldNames = lines.at( 0 ).split( '\t' );`
`268`	`268`	`//wkt / text always has wkt_geom as first attribute (however values can be NULL)`
`269`		`- if ( fieldNames.at( 0 ) != "wkt_geom" )`
	`269`	`+ if ( fieldNames.at( 0 ) != QLatin1String( "wkt_geom" ) )`
`270`	`270`	`{`
`271`	`271`	`return f;`
`272`	`272`	`}`
`273`	`273`
`274`	`274`	`for ( int i = 0; i < fieldNames.size(); ++i )`
`275`	`275`	`{`
`276`	`276`	`QString fieldName = fieldNames.at( i );`
`277`		`- if ( fieldName == "wkt_geom" )`
	`277`	`+ if ( fieldName == QLatin1String( "wkt_geom" ) )`
`278`	`278`	`{`
`279`	`279`	`continue;`
`280`	`280`	`}`