Fix clazy return void warnings

nyalldawson · nyalldawson · commit bf413bc6cd65 · 2018-02-02T19:52:01.000+11:00
diff --git a/src/analysis/vector/qgsgeometrysnapper.h b/src/analysis/vector/qgsgeometrysnapper.h
@@ -96,7 +96,7 @@ class ANALYSIS_EXPORT QgsGeometrySnapper : public QObject
         , snapTolerance( snapTolerance )
         , mode( mode )
       {}
-      void operator()( QgsFeature &feature ) { return instance->processFeature( feature, snapTolerance, mode ); }
+      void operator()( QgsFeature &feature ) { instance->processFeature( feature, snapTolerance, mode ); }
     };
 
     enum PointFlag { SnappedToRefNode, SnappedToRefSegment, Unsnapped };
diff --git a/src/core/qgssettings.cpp b/src/core/qgssettings.cpp
@@ -189,7 +189,7 @@ QString QgsSettings::fileName() const
 
 void QgsSettings::sync()
 {
-  return mUserSettings->sync();
+  mUserSettings->sync();
 }
 
 void QgsSettings::remove( const QString &key, const QgsSettings::Section section )
diff --git a/src/core/symbology/qgspointdistancerenderer.cpp b/src/core/symbology/qgspointdistancerenderer.cpp
@@ -193,7 +193,7 @@ void QgsPointDistanceRenderer::checkLegendSymbolItem( const QString &key, bool s
   if ( !mRenderer )
     return;
 
-  return mRenderer->checkLegendSymbolItem( key, state );
+  mRenderer->checkLegendSymbolItem( key, state );
 }
 
 QString QgsPointDistanceRenderer::filter( const QgsFields &fields )
diff --git a/src/gui/qgsrasterlayersaveasdialog.h b/src/gui/qgsrasterlayersaveasdialog.h
@@ -87,7 +87,7 @@ class GUI_EXPORT QgsRasterLayerSaveAsDialog: public QDialog, private Ui::QgsRast
     void hideOutput();
 
   public slots:
-    void accept() override { if ( validate() ) return QDialog::accept(); }
+    void accept() override { if ( validate() ) QDialog::accept(); }
 
   private slots:
     void mRawModeRadioButton_toggled( bool );
diff --git a/src/gui/qgsscalewidget.cpp b/src/gui/qgsscalewidget.cpp
@@ -61,5 +61,5 @@ void QgsScaleWidget::setScaleFromCanvas()
 
 void QgsScaleWidget::setScale( double scale )
 {
-  return mScaleComboBox->setScale( scale );
+  mScaleComboBox->setScale( scale );
 }

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ QString QgsSettings::fileName() const`
`189`	`189`
`190`	`190`	`void QgsSettings::sync()`
`191`	`191`	`{`
`192`		`- return mUserSettings->sync();`
	`192`	`+ mUserSettings->sync();`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`void QgsSettings::remove( const QString &key, const QgsSettings::Section section )`
Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ void QgsPointDistanceRenderer::checkLegendSymbolItem( const QString &key, bool s`
`193`	`193`	`if ( !mRenderer )`
`194`	`194`	`return;`
`195`	`195`
`196`		`- return mRenderer->checkLegendSymbolItem( key, state );`
	`196`	`+ mRenderer->checkLegendSymbolItem( key, state );`
`197`	`197`	`}`
`198`	`198`
`199`	`199`	`QString QgsPointDistanceRenderer::filter( const QgsFields &fields )`
Original file line number	Diff line number	Diff line change
`@@ -61,5 +61,5 @@ void QgsScaleWidget::setScaleFromCanvas()`
`61`	`61`
`62`	`62`	`void QgsScaleWidget::setScale( double scale )`
`63`	`63`	`{`
`64`		`- return mScaleComboBox->setScale( scale );`
	`64`	`+ mScaleComboBox->setScale( scale );`
`65`	`65`	`}`