qgis · May 28, 2019
diff --git a/‎src/server/services/wfs/qgswfsdescribefeaturetype.cpp
Lines changed: 1 addition & 1 deletion b/‎src/server/services/wfs/qgswfsdescribefeaturetype.cpp
Lines changed: 1 addition & 1 deletion
diff --git a/‎tests/src/python/test_qgsserver_wfs.py
Lines changed: 7 additions & 0 deletions b/‎tests/src/python/test_qgsserver_wfs.py
Lines changed: 7 additions & 0 deletions
diff --git a/‎tests/testdata/qgis_server/bug_gh29767_double_vfield.qgs
Lines changed: 711 additions & 0 deletions b/‎tests/testdata/qgis_server/bug_gh29767_double_vfield.qgs
Lines changed: 711 additions & 0 deletions
diff --git a/‎tests/testdata/qgis_server/wfs_describeFeatureType_1_1_0_virtual_fields.txt
Lines changed: 21 additions & 0 deletions b/‎tests/testdata/qgis_server/wfs_describeFeatureType_1_1_0_virtual_fields.txt
Lines changed: 21 additions & 0 deletions
@@ -291,7 +291,7 @@ namespace QgsWfs
         }
         else if ( attributeType == QVariant::Double )
         {
-          if ( field.length() != 0 && field.precision() == 0 )
+          if ( field.length() > 0 && field.precision() == 0 )
             attElem.setAttribute( QStringLiteral( "type" ), QStringLiteral( "integer" ) );
           else
             attElem.setAttribute( QStringLiteral( "type" ), QStringLiteral( "decimal" ) );
 
@@ -454,6 +454,13 @@ def test_describeFeatureType(self):
         self.wfs_request_compare("DescribeFeatureType", '1.1.0', "TYPENAME=does_not_exist&",
                                  'wfs_describeFeatureType_1_1_0_typename_wrong', project_file=project_file)
 
+    def test_describeFeatureTypeVirtualFields(self):
+        """Test DescribeFeatureType with virtual fields: bug GH-29767"""
+
+        project_file = "bug_gh29767_double_vfield.qgs"
+        self.wfs_request_compare("DescribeFeatureType", '1.1.0', "",
+                                 'wfs_describeFeatureType_1_1_0_virtual_fields', project_file=project_file)
+
     def test_getFeatureFeature_0_nulls(self):
         """Test that 0 and null in integer columns are reported correctly"""
 
 
@@ -0,0 +1,21 @@
+
+Content-Type: text/xml; charset=utf-8
+
+<schema xmlns:gml="http://www.opengis.net/gml" targetNamespace="http://www.qgis.org/gml" xmlns:qgs="http://www.qgis.org/gml" xmlns="http://www.w3.org/2001/XMLSchema" xmlns:ogc="http://www.opengis.net/ogc" version="1.0" xmlns:xsd="http://www.w3.org/2001/XMLSchema" elementFormDefault="qualified">
+ <import namespace="http://www.opengis.net/gml" schemaLocation="http://schemas.opengis.net/gml/3.1.1/base/gml.xsd"/>
+ <element type="qgs:layer_with_short_nameType" name="layer_with_short_name" substitutionGroup="gml:_Feature"/>
+ <complexType name="layer_with_short_nameType">
+  <complexContent>
+   <extension base="gml:AbstractFeatureType">
+    <sequence>
+     <element maxOccurs="1" type="gml:PointPropertyType" minOccurs="0" name="geometry"/>
+     <element type="long" nillable="true" name="id"/>
+     <element type="string" nillable="true" name="name"/>
+     <element type="string" nillable="true" name="utf8nameè"/>
+     <element type="decimal" nillable="true" name="virtdbl"/>
+     <element type="int" nillable="true" name="virtint"/>
+    </sequence>
+   </extension>
+  </complexContent>
+ </complexType>
+</schema>
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ namespace QgsWfs`
`291`	`291`	`}`
`292`	`292`	`else if ( attributeType == QVariant::Double )`
`293`	`293`	`{`
`294`		`- if ( field.length() != 0 && field.precision() == 0 )`
	`294`	`+ if ( field.length() > 0 && field.precision() == 0 )`
`295`	`295`	`attElem.setAttribute( QStringLiteral( "type" ), QStringLiteral( "integer" ) );`
`296`	`296`	`else`
`297`	`297`	`attElem.setAttribute( QStringLiteral( "type" ), QStringLiteral( "decimal" ) );`