Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
code layout + suggestions from Nyall
  • Loading branch information
wonder-sk committed Jan 20, 2021
1 parent 3024694 commit be3e751
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/core/qgstiledownloadmanager.cpp
Expand Up @@ -146,7 +146,7 @@ QgsTileDownloadManager::QgsTileDownloadManager()

QgsTileDownloadManager::~QgsTileDownloadManager()
{
// make sure the worker thread is gone and any pending requests are cancelled
// make sure the worker thread is gone and any pending requests are canceled
shutdown();
}

Expand Down
6 changes: 4 additions & 2 deletions src/core/qgstiledownloadmanager.h
Expand Up @@ -18,6 +18,8 @@
#ifndef QGSTILEDOWNLOADMANAGER_H
#define QGSTILEDOWNLOADMANAGER_H

#define SIP_NO_FILE

#include <QTimer>
#include <QThread>
#include <QMutex>
Expand Down Expand Up @@ -152,9 +154,9 @@ class QgsTileDownloadManagerWorker : public QObject
*
* - a map rendering job starts which requests tiles from a remote server, then in a short
* while user zooms/pans map, which would normally mean that all pending requests get
* aborted and then restarted soon afterwards. The download manager lets the requests
* aborted and then restarted soon afterwards. The download manager allows the requests
* to finish to avoid excessive load on servers and needless aborts and repeated requests.
* - multiple map rendering jobs start at a similar time, requesting map the same map tiles.
* - multiple map rendering jobs start at a similar time, requesting the same map tiles.
* Normally they could be requested multiple times from the server - the download manager
* groups these requests and only does a single request at a time.
*
Expand Down

0 comments on commit be3e751

Please sign in to comment.