Add test

nyalldawson · nyalldawson · commit be1e3f203fb8 · 2023-03-31T14:22:44.000+10:00
diff --git a/src/core/layertree/qgslayertreemodellegendnode.cpp b/src/core/layertree/qgslayertreemodellegendnode.cpp
@@ -352,9 +352,9 @@ QgsSymbolLegendNode::~QgsSymbolLegendNode() = default;
 Qt::ItemFlags QgsSymbolLegendNode::flags() const
 {
   if ( mItem.isCheckable() )
-    return Qt::ItemIsEnabled | Qt::ItemIsUserCheckable;
+    return Qt::ItemIsEnabled | Qt::ItemIsUserCheckable | Qt::ItemIsSelectable;
   else
-    return Qt::ItemIsEnabled;
+    return Qt::ItemIsEnabled | Qt::ItemIsSelectable;
 }
 
 
@@ -1043,9 +1043,9 @@ QgsRasterSymbolLegendNode::QgsRasterSymbolLegendNode( QgsLayerTreeLayer *nodeLay
 Qt::ItemFlags QgsRasterSymbolLegendNode::flags() const
 {
   if ( mCheckable )
-    return Qt::ItemIsEnabled | Qt::ItemIsUserCheckable;
+    return Qt::ItemIsEnabled | Qt::ItemIsUserCheckable | Qt::ItemIsSelectable;
   else
-    return Qt::ItemIsEnabled;
+    return Qt::ItemIsEnabled | Qt::ItemIsSelectable;
 }
 
 QVariant QgsRasterSymbolLegendNode::data( int role ) const
diff --git a/tests/src/python/test_qgslayertreeview.py b/tests/src/python/test_qgslayertreeview.py
@@ -10,13 +10,17 @@
 __copyright__ = 'Copyright 2018, The QGIS Project'
 
 import qgis  # NOQA
-from qgis.PyQt.QtCore import QStringListModel
+from qgis.PyQt.QtCore import QStringListModel, QItemSelectionModel
 from qgis.PyQt.QtTest import QAbstractItemModelTester, QSignalSpy
 from qgis.core import (
     QgsLayerTree,
     QgsLayerTreeModel,
     QgsProject,
     QgsVectorLayer,
+    QgsCategorizedSymbolRenderer,
+    QgsRendererCategory,
+    QgsMarkerSymbol,
+    QgsMapLayerLegend
 )
 from qgis.gui import QgsLayerTreeView, QgsLayerTreeViewDefaultActions
 from qgis.testing import start_app, unittest
@@ -655,6 +659,43 @@ def testNode2IndexMethods(self):
         tree_layer2_index = view.node2sourceIndex(node2)
         self.assertEqual(tree_layer2_index, view.node2sourceIndex(node2))
 
+    def test_selected_legend_nodes(self):
+        layer = QgsVectorLayer("Point?field=fldtxt:string",
+                               "layer1", "memory")
+
+        cat1 = QgsRendererCategory(1, QgsMarkerSymbol.createSimple({}), 'cat 1')
+        cat2 = QgsRendererCategory(2, QgsMarkerSymbol.createSimple({}),
+                                   'cat 2')
+        cat3 = QgsRendererCategory(1, QgsMarkerSymbol.createSimple({}),
+                                   'cat 3')
+
+        renderer = QgsCategorizedSymbolRenderer('fldtext', [cat1, cat2, cat3])
+        layer.setRenderer(renderer)
+        layer.setLegend(QgsMapLayerLegend.defaultVectorLegend(layer))
+
+        root = QgsLayerTree()
+        model = QgsLayerTreeModel(root)
+        layer_tree_layer = root.addLayer(layer)
+        view = QgsLayerTreeView()
+        view.setModel(model)
+
+        legend_nodes = model.layerLegendNodes(layer_tree_layer)
+        self.assertEqual(len(legend_nodes), 3)
+
+        index = model.legendNode2index(legend_nodes[0])
+        self.assertTrue(index.isValid())
+        self.assertEqual(model.index2legendNode(index), legend_nodes[0])
+        index2 = model.legendNode2index(legend_nodes[2])
+        self.assertTrue(index2.isValid())
+        self.assertEqual(model.index2legendNode(index2), legend_nodes[2])
+
+        self.assertFalse(view.selectedLegendNodes())
+
+        view.selectionModel().select(view.proxyModel().mapFromSource(index), QItemSelectionModel.ClearAndSelect)
+        view.selectionModel().select(view.proxyModel().mapFromSource(index2), QItemSelectionModel.Select)
+
+        self.assertCountEqual(view.selectedLegendNodes(), [legend_nodes[0], legend_nodes[2]])
+
 
 if __name__ == '__main__':
     unittest.main()

Original file line number	Diff line number	Diff line change
`@@ -352,9 +352,9 @@ QgsSymbolLegendNode::~QgsSymbolLegendNode() = default;`
`352`	`352`	`Qt::ItemFlags QgsSymbolLegendNode::flags() const`
`353`	`353`	`{`
`354`	`354`	`if ( mItem.isCheckable() )`
`355`		`- return Qt::ItemIsEnabled \| Qt::ItemIsUserCheckable;`
	`355`	`+ return Qt::ItemIsEnabled \| Qt::ItemIsUserCheckable \| Qt::ItemIsSelectable;`
`356`	`356`	`else`
`357`		`- return Qt::ItemIsEnabled;`
	`357`	`+ return Qt::ItemIsEnabled \| Qt::ItemIsSelectable;`
`358`	`358`	`}`
`359`	`359`
`360`	`360`
`@@ -1043,9 +1043,9 @@ QgsRasterSymbolLegendNode::QgsRasterSymbolLegendNode( QgsLayerTreeLayer *nodeLay`
`1043`	`1043`	`Qt::ItemFlags QgsRasterSymbolLegendNode::flags() const`
`1044`	`1044`	`{`
`1045`	`1045`	`if ( mCheckable )`
`1046`		`- return Qt::ItemIsEnabled \| Qt::ItemIsUserCheckable;`
	`1046`	`+ return Qt::ItemIsEnabled \| Qt::ItemIsUserCheckable \| Qt::ItemIsSelectable;`
`1047`	`1047`	`else`
`1048`		`- return Qt::ItemIsEnabled;`
	`1048`	`+ return Qt::ItemIsEnabled \| Qt::ItemIsSelectable;`
`1049`	`1049`	`}`
`1050`	`1050`
`1051`	`1051`	`QVariant QgsRasterSymbolLegendNode::data( int role ) const`