Do not emit changed signal if the value has not really changed

NULL case
qgis · Jun 7, 2019 · bde5561 · bde5561
1 parent cd42d65
commit bde5561
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/gui/editorwidgets/qgsdatetimeedit.cpp b/src/gui/editorwidgets/qgsdatetimeedit.cpp
@@ -62,7 +62,11 @@ void QgsDateTimeEdit::clear()
   {
     displayNull();
 
-    changed( QDateTime() );
+    // Check if it's really changed or crash, see GH #29937
+    if ( ! dateTime().isNull() )
+    {
+      changed( QDateTime() );
+    }
 
     // emit signal of QDateTime::dateTimeChanged with an invalid date
     // anyway, using parent's signal should be avoided
@@ -252,6 +256,7 @@ void QgsDateTimeEdit::setDateTime( const QDateTime &dateTime )
   {
     clear();
   }
+  // Check if it's really changed or crash, see GH #29937
   else if ( dateTime != QgsDateTimeEdit::dateTime() )
   {
     QDateTimeEdit::setDateTime( dateTime );