Skip to content

Commit bd58bc3

Browse files
committedMar 2, 2017
oracle provider: update qocispatial driver for/from Qt5
* handling of private data * rely on implicit byte array sharing instead of using data pointers * sync with qoci
1 parent febff07 commit bd58bc3

File tree

8 files changed

+345
-325
lines changed

8 files changed

+345
-325
lines changed
 

‎src/providers/oracle/ocispatial/CMakeLists.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,15 @@ ADD_DEFINITIONS(-DQT_PLUGIN)
99
ADD_DEFINITIONS(-DQT_NO_DEBUG)
1010
ADD_DEFINITIONS(-DQT_SHARED)
1111

12-
INCLUDE_DIRECTORIES(SYSTEM ${OCI_INCLUDE_DIR})
12+
INCLUDE_DIRECTORIES(SYSTEM
13+
${OCI_INCLUDE_DIR}
14+
${Qt5Sql_PRIVATE_INCLUDE_DIRS}
15+
)
1316

1417
SET(QSQLOCISPATIAL_SRC qsql_ocispatial.cpp main.cpp)
15-
QT5_WRAP_CPP(QSQLOCISPATIAL_SRC qsql_ocispatial.h main.h)
18+
QT5_WRAP_CPP(QSQLOCISPATIAL_MOC_SRC qsql_ocispatial.h main.h)
1619

17-
ADD_LIBRARY(qsqlocispatial SHARED ${QSQLOCISPATIAL_SRC})
20+
ADD_LIBRARY(qsqlocispatial SHARED ${QSQLOCISPATIAL_SRC} ${QSQLOCISPATIAL_MOC_SRC})
1821

1922
TARGET_LINK_LIBRARIES(qsqlocispatial
2023
${QT_QTCORE_LIBRARY}

‎src/providers/oracle/ocispatial/main.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,9 @@
4242
****************************************************************************/
4343

4444
#include "main.h"
45+
#include <qsqldriverplugin.h>
4546
#include "qsql_ocispatial.h"
4647

47-
QT_BEGIN_NAMESPACE
48-
4948
QOCISpatialDriverPlugin::QOCISpatialDriverPlugin()
5049
: QSqlDriverPlugin()
5150
{
@@ -60,12 +59,3 @@ QSqlDriver* QOCISpatialDriverPlugin::create( const QString &name )
6059
}
6160
return 0;
6261
}
63-
64-
QStringList QOCISpatialDriverPlugin::keys() const
65-
{
66-
QStringList l;
67-
l << QLatin1String( "QOCISPATIAL8" ) << QLatin1String( "QOCISPATIAL" );
68-
return l;
69-
}
70-
71-
QT_END_NAMESPACE

‎src/providers/oracle/ocispatial/main.h

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,21 +41,16 @@
4141
**
4242
****************************************************************************/
4343

44-
#ifndef QOCISPATIAL_MAIN_H
45-
#define QOCISPATIAL_MAIN_H
46-
47-
#include <QSqlDriverPlugin>
48-
#include <QStringList>
44+
#include <qsqldriverplugin.h>
45+
#include "qsql_ocispatial.h"
4946

5047
class QOCISpatialDriverPlugin : public QSqlDriverPlugin
5148
{
5249
Q_OBJECT
5350
Q_PLUGIN_METADATA( IID "org.qt-project.Qt.QSqlDriverFactoryInterface" FILE "qocispatial.json" )
51+
5452
public:
5553
QOCISpatialDriverPlugin();
5654

5755
QSqlDriver* create( const QString & );
58-
QStringList keys() const;
5956
};
60-
61-
#endif

0 commit comments

Comments
 (0)
Please sign in to comment.