Fix clazy qvariant-template-instantiation warning

From the clazy docs: Detects when you're using QVariant::value<Foo>() instead of QVariant::toFoo(). The former results in more code being generated.
qgis · Oct 22, 2016 · bd20fe4 · bd20fe4
1 parent ad13699
commit bd20fe4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/app/qgsbookmarks.cpp b/src/app/qgsbookmarks.cpp
@@ -674,8 +674,8 @@ void QgsMergedBookmarksTableModel::moveBookmark( QAbstractTableModel& modelFrom,
                      "  VALUES (NULL,:name,:project_name,:xmin,:xmax,:ymin,:ymax,:projection_srid)",
                      qgisModel->database() );
 
-    query.bindValue( ":name", modelFrom.data( modelFrom.index( row, 1 ) ).value<QString>() );
-    query.bindValue( ":project_name", modelFrom.data( modelFrom.index( row, 2 ) ).value<QString>() );
+    query.bindValue( ":name", modelFrom.data( modelFrom.index( row, 1 ) ).toString() );
+    query.bindValue( ":project_name", modelFrom.data( modelFrom.index( row, 2 ) ).toString() );
     query.bindValue( ":xmin", modelFrom.data( modelFrom.index( row, 3 ) ).toDouble() );
     query.bindValue( ":ymin", modelFrom.data( modelFrom.index( row, 4 ) ).toDouble() );
     query.bindValue( ":xmax", modelFrom.data( modelFrom.index( row, 5 ) ).toDouble() );

diff --git a/src/gui/attributetable/qgsdualview.cpp b/src/gui/attributetable/qgsdualview.cpp
@@ -360,7 +360,7 @@ void QgsDualView::copyCellContent() const
 
   if ( action && action->data().isValid() && action->data().canConvert<QModelIndex>() )
   {
-    QModelIndex index = action->data().value<QModelIndex>();
+    QModelIndex index = action->data().toModelIndex();
     QVariant var = masterModel()->data( index, Qt::DisplayRole );
     QApplication::clipboard()->setText( var.toString() );
   }