fix #1789

jef · jef · commit bcf09abbc00b · 2009-07-18T17:52:06.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk@11105 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/qgspgquerybuilder.cpp b/src/app/qgspgquerybuilder.cpp
@@ -187,7 +187,7 @@ void QgsPgQueryBuilder::fillValues( QString theSQL )
 
   // determine the field type
   QgsField field = mFieldMap[mModelFields->data( lstFields->currentIndex() ).toString()];
-  mActualFieldIsChar = field.typeName().contains( "char" ) || field.typeName().contains( "text" ); // really should be: field.type()==QVariant::String - but is not set correctly above
+  mQuoteValue = field.typeName().contains( "char" ) || field.typeName().contains( "text" ) || field.typeName().contains("bool"); // really should be: field.type()==QVariant::String - but is not set correctly above
 
   PGresult *result = PQexec( mPgConnection, theSQL.toUtf8() );
 
@@ -429,7 +429,7 @@ void QgsPgQueryBuilder::on_lstFields_doubleClicked( const QModelIndex &index )
 
 void QgsPgQueryBuilder::on_lstValues_doubleClicked( const QModelIndex &index )
 {
-  if ( mActualFieldIsChar )
+  if ( mQuoteValue )
   {
     txtSQL->insertPlainText( "'" + mModelValues->data( index ).toString() + "'" );
   }
diff --git a/src/app/qgspgquerybuilder.h b/src/app/qgspgquerybuilder.h
@@ -153,8 +153,8 @@ class QgsPgQueryBuilder : public QDialog, private Ui::QgsPgQueryBuilderBase
     QStandardItemModel *mModelFields;
     //! Model for values ListView
     QStandardItemModel *mModelValues;
-    //! Actual field char?
-    bool mActualFieldIsChar;
+    //! value needs to be quoted (char, boolean)
+    bool mQuoteValue;
     //! Previous field row to delete model
     int mPreviousFieldRow;
 };

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ void QgsPgQueryBuilder::fillValues( QString theSQL )`
`187`	`187`
`188`	`188`	`// determine the field type`
`189`	`189`	`QgsField field = mFieldMap[mModelFields->data( lstFields->currentIndex() ).toString()];`
`190`		`- mActualFieldIsChar = field.typeName().contains( "char" ) \|\| field.typeName().contains( "text" ); // really should be: field.type()==QVariant::String - but is not set correctly above`
	`190`	`+ mQuoteValue = field.typeName().contains( "char" ) \|\| field.typeName().contains( "text" ) \|\| field.typeName().contains("bool"); // really should be: field.type()==QVariant::String - but is not set correctly above`
`191`	`191`
`192`	`192`	`PGresult *result = PQexec( mPgConnection, theSQL.toUtf8() );`
`193`	`193`
`@@ -429,7 +429,7 @@ void QgsPgQueryBuilder::on_lstFields_doubleClicked( const QModelIndex &index )`
`429`	`429`
`430`	`430`	`void QgsPgQueryBuilder::on_lstValues_doubleClicked( const QModelIndex &index )`
`431`	`431`	`{`
`432`		`- if ( mActualFieldIsChar )`
	`432`	`+ if ( mQuoteValue )`
`433`	`433`	`{`
`434`	`434`	`txtSQL->insertPlainText( "'" + mModelValues->data( index ).toString() + "'" );`
`435`	`435`	`}`