avoid duplication of points in rubberbands of point geometry

qgis · Aug 14, 2013 · bc58898 · bc58898
1 parent 63cf5d3
commit bc58898
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/gui/qgsrubberband.cpp b/src/gui/qgsrubberband.cpp
@@ -190,9 +190,9 @@ void QgsRubberBand::removePoint( int index, bool doUpdate/* = true*/, int geomet
   }
 }
 
-void QgsRubberBand::removeLastPoint( int geometryIndex )
+void QgsRubberBand::removeLastPoint( int geometryIndex, bool doUpdate/* = true*/ )
 {
-  removePoint( -1, true, geometryIndex );
+  removePoint( -1, doUpdate, geometryIndex );
 }
 
 /*!
@@ -272,6 +272,7 @@ void QgsRubberBand::addGeometry( QgsGeometry* geom, QgsVectorLayer* layer )
         pt = geom->asPoint();
       }
       addPoint( pt, false, idx );
+      removeLastPoint( idx , false );
     }
     break;
 
@@ -285,10 +286,12 @@ void QgsRubberBand::addGeometry( QgsGeometry* geom, QgsVectorLayer* layer )
         if ( layer )
         {
           addPoint( mr->layerToMapCoordinates( layer, pt ), false, idx );
+          removeLastPoint( idx , false );
         }
         else
         {
           addPoint( pt, false, idx );
+          removeLastPoint( idx , false );
         }
       }
     }

diff --git a/src/gui/qgsrubberband.h b/src/gui/qgsrubberband.h
@@ -149,7 +149,7 @@ class GUI_EXPORT QgsRubberBand: public QgsMapCanvasItem
     /**
      * Removes the last point. Most useful in connection with undo operations
      */
-    void removeLastPoint( int geometryIndex = 0 );
+    void removeLastPoint( int geometryIndex = 0 , bool doUpdate = true );
 
     /**
      * Moves the rubber band point specified by index. Note that if the rubber band is