The store can now add invalid maplayers

qgis · Nov 5, 2018 · bc4a1ef · bc4a1ef
1 parent bac5fbb
commit bc4a1ef
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/python/core/auto_generated/qgsmaplayerstore.sip.in b/python/core/auto_generated/qgsmaplayerstore.sip.in
@@ -104,7 +104,7 @@ The layersAdded() and layerWasAdded() signals will always be emitted.
                       the layers yourself. Not available in Python.
 
 :return: a list of the map layers that were added
-         successfully. If a layer is invalid, or already exists in the store,
+         successfully. If a layer already exists in the store,
          it will not be part of the returned list.
 
 

diff --git a/src/core/qgsmaplayerstore.cpp b/src/core/qgsmaplayerstore.cpp
@@ -55,9 +55,9 @@ QList<QgsMapLayer *> QgsMapLayerStore::addMapLayers( const QList<QgsMapLayer *>
   QList<QgsMapLayer *> myResultList;
   Q_FOREACH ( QgsMapLayer *myLayer, layers )
   {
-    if ( !myLayer || !myLayer->isValid() )
+    if ( !myLayer )
     {
-      QgsDebugMsg( QStringLiteral( "Cannot add invalid layers" ) );
+      QgsDebugMsg( QStringLiteral( "Cannot add null layers" ) );
       continue;
     }
     //check the layer is not already registered!

diff --git a/src/core/qgsmaplayerstore.h b/src/core/qgsmaplayerstore.h
@@ -135,7 +135,7 @@ class CORE_EXPORT QgsMapLayerStore : public QObject
      *                      the layers yourself. Not available in Python.
      *
      * \returns a list of the map layers that were added
-     *         successfully. If a layer is invalid, or already exists in the store,
+     *         successfully. If a layer already exists in the store,
      *         it will not be part of the returned list.
      *
      * \see addMapLayer()