Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Double-click handling, changed current layer handling
  • Loading branch information
wonder-sk committed May 21, 2014
1 parent ca97459 commit bbdf144
Show file tree
Hide file tree
Showing 4 changed files with 65 additions and 18 deletions.
29 changes: 28 additions & 1 deletion src/app/qgisapp.cpp
Expand Up @@ -375,6 +375,30 @@ void QgisApp::emitCustomSrsValidation( QgsCoordinateReferenceSystem &srs )
emit customSrsValidation( srs );
}

void QgisApp::layerTreeViewDoubleClicked(const QModelIndex& index)
{
Q_UNUSED( index );

QSettings settings;
switch ( settings.value( "/qgis/legendDoubleClickAction", 0 ).toInt() )
{
case 0:
QgisApp::instance()->layerProperties();
break;
case 1:
QgisApp::instance()->attributeTable();
break;
default:
break;
}
}

void QgisApp::activeLayerChanged(QgsMapLayer* layer)
{
if ( mMapCanvas )
mMapCanvas->setCurrentLayer( layer );
}

/**
* This function contains forced validation of CRS used in QGIS.
* There are 3 options depending on the settings:
Expand Down Expand Up @@ -2359,6 +2383,9 @@ void QgisApp::initLayerTreeView()
mLayerTreeView->setModel( model );
mLayerTreeView->setMenuProvider( new QgsAppLayerTreeViewMenuProvider(mLayerTreeView, mMapCanvas) );

connect( mLayerTreeView, SIGNAL(doubleClicked(QModelIndex)), this, SLOT(layerTreeViewDoubleClicked(QModelIndex)) );
connect( mLayerTreeView, SIGNAL(currentLayerChanged(QgsMapLayer*)), this, SLOT(activeLayerChanged(QgsMapLayer*)) );

mLayerTreeDock->setWidget( mLayerTreeView );
addDockWidget( Qt::LeftDockWidgetArea, mLayerTreeDock );
}
Expand Down Expand Up @@ -7474,7 +7501,7 @@ void QgisApp::openURL( QString url, bool useQgisDocDirectory )
/** Get a pointer to the currently selected map layer */
QgsMapLayer *QgisApp::activeLayer()
{
return mMapLegend ? mMapLegend->currentLayer() : 0;
return mLayerTreeView ? mLayerTreeView->currentLayer() : 0;
}

/** set the current layer */
Expand Down
2 changes: 2 additions & 0 deletions src/app/qgisapp.h
Expand Up @@ -466,6 +466,8 @@ class APP_EXPORT QgisApp : public QMainWindow, private Ui::MainWindow
#endif

public slots:
void layerTreeViewDoubleClicked(const QModelIndex& index);
void activeLayerChanged(QgsMapLayer* layer);
//! Zoom to full extent
void zoomFull();
//! Zoom to the previous extent
Expand Down
46 changes: 32 additions & 14 deletions src/gui/layertree/qgslayertreeview.cpp
Expand Up @@ -9,7 +9,6 @@

QgsLayerTreeView::QgsLayerTreeView(QWidget *parent)
: QTreeView(parent)
, mCurrentLayer(0)
, mDefaultActions(0)
, mMenuProvider(0)
{
Expand All @@ -18,6 +17,7 @@ QgsLayerTreeView::QgsLayerTreeView(QWidget *parent)
setDragEnabled(true);
setAcceptDrops(true);
setDropIndicatorShown(true);
setEditTriggers(EditKeyPressed | SelectedClicked);

setSelectionMode(ExtendedSelection);

Expand All @@ -39,7 +39,7 @@ void QgsLayerTreeView::setModel(QAbstractItemModel* model)

QTreeView::setModel(model);

connect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), this, SLOT(onCurrentChanged(QModelIndex)));
connect(selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), this, SLOT(onCurrentChanged(QModelIndex,QModelIndex)));

updateExpandedStateFromNode(layerTreeModel()->rootGroup());
}
Expand All @@ -64,16 +64,16 @@ void QgsLayerTreeView::setMenuProvider(QgsLayerTreeViewMenuProvider* menuProvide

QgsMapLayer* QgsLayerTreeView::currentLayer() const
{
return mCurrentLayer;
return layerForIndex( currentIndex() );
}

void QgsLayerTreeView::setCurrentLayer(QgsMapLayer* layer)
{
if (mCurrentLayer == layer)
QgsLayerTreeLayer* nodeLayer = layerTreeModel()->rootGroup()->findLayer(layer->id());
if (!nodeLayer)
return;

mCurrentLayer = layer;
emit currentLayerChanged(mCurrentLayer);
setCurrentIndex( layerTreeModel()->node2index(nodeLayer) );
}


Expand Down Expand Up @@ -117,17 +117,16 @@ void QgsLayerTreeView::updateExpandedStateToNode(QModelIndex index)
node->setExpanded(isExpanded(index));
}

void QgsLayerTreeView::onCurrentChanged(QModelIndex current)
void QgsLayerTreeView::onCurrentChanged(QModelIndex current, QModelIndex previous)
{
QgsLayerTreeNode* node = layerTreeModel()->index2node(current);
if (!node)
return; // TODO: maybe also support symbology nodes
QgsMapLayer* layerPrevious = layerForIndex(previous);
QgsMapLayer* layerCurrent = layerForIndex(current);

QgsMapLayer* layer = 0;
if (node->nodeType() == QgsLayerTreeNode::NodeLayer)
layer = static_cast<QgsLayerTreeLayer*>(node)->layer();
if (layerPrevious == layerCurrent)
return;

setCurrentLayer(layer);
qDebug("current layer changed!");
emit currentLayerChanged(layerCurrent);
}

void QgsLayerTreeView::updateExpandedStateFromNode(QgsLayerTreeNode* node)
Expand All @@ -139,6 +138,25 @@ void QgsLayerTreeView::updateExpandedStateFromNode(QgsLayerTreeNode* node)
updateExpandedStateFromNode(child);
}

QgsMapLayer* QgsLayerTreeView::layerForIndex(const QModelIndex& index) const
{
QgsLayerTreeNode* node = layerTreeModel()->index2node(index);
if (node)
{
if (node->nodeType() == QgsLayerTreeNode::NodeLayer)
return static_cast<QgsLayerTreeLayer*>(node)->layer();
}
else
{
// possibly a symbology node
QgsLayerTreeModelSymbologyNode* symnode = layerTreeModel()->index2symnode(index);
if (symnode)
return symnode->parent()->layer();
}

return 0;
}

QgsLayerTreeNode* QgsLayerTreeView::currentNode() const
{
return layerTreeModel()->index2node(selectionModel()->currentIndex());
Expand Down
6 changes: 3 additions & 3 deletions src/gui/layertree/qgslayertreeview.h
Expand Up @@ -41,6 +41,8 @@ class GUI_EXPORT QgsLayerTreeView : public QTreeView

void updateExpandedStateFromNode(QgsLayerTreeNode* node);

QgsMapLayer* layerForIndex(const QModelIndex& index) const;

signals:
void currentLayerChanged(QgsMapLayer* layer);

Expand All @@ -52,11 +54,9 @@ protected slots:

void updateExpandedStateToNode(QModelIndex index);

void onCurrentChanged(QModelIndex current);
void onCurrentChanged(QModelIndex current, QModelIndex previous);

protected:
QgsMapLayer* mCurrentLayer;

QgsLayerTreeViewDefaultActions* mDefaultActions;
QgsLayerTreeViewMenuProvider* mMenuProvider;
};
Expand Down

0 comments on commit bbdf144

Please sign in to comment.