Fix font size not restoring when opening label property dialog

Also make font size of 0 correspond to a null value, ie the label uses the default layer font size.
qgis · Jan 18, 2015 · bb7e53c · bb7e53c
1 parent 6a65050
commit bb7e53c
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/src/app/qgslabelpropertydialog.cpp b/src/app/qgslabelpropertydialog.cpp
@@ -262,8 +262,19 @@ void QgsLabelPropertyDialog::init( const QString& layerId, int featureId, const
         mFontItalicBtn->setEnabled( true );
         break;
       case QgsPalLayerSettings::Size:
+      {
         mFontSizeSpinBox->setEnabled( true );
+        double size = mCurLabelFeat.attribute( ddIndx ).toDouble( &ok );
+        if ( ok )
+        {
+          mFontSizeSpinBox->setValue( size );
+        }
+        else
+        {
+          mFontSizeSpinBox->setValue( 0 );
+        }
         break;
+      }
       default:
         break;
     }
@@ -329,13 +340,13 @@ void QgsLabelPropertyDialog::updateFont( const QFont& font, bool block )
 
   if ( block )
     blockElementSignals( true );
+
   mFontFamilyCmbBx->setCurrentFont( mLabelFont );
   populateFontStyleComboBox();
   mFontUnderlineBtn->setChecked( mLabelFont.underline() );
   mFontStrikethroughBtn->setChecked( mLabelFont.strikeOut() );
   mFontBoldBtn->setChecked( mLabelFont.bold() );
   mFontItalicBtn->setChecked( mLabelFont.italic() );
-  mFontSizeSpinBox->setValue( mLabelFont.pointSizeF() );
   if ( block )
     blockElementSignals( false );
 }
@@ -452,7 +463,13 @@ void QgsLabelPropertyDialog::on_mFontItalicBtn_toggled( bool ckd )
 
 void QgsLabelPropertyDialog::on_mFontSizeSpinBox_valueChanged( double d )
 {
-  insertChangedValue( QgsPalLayerSettings::Size, d );
+  QVariant size( d );
+  if ( d <= 0 )
+  {
+    //null value so that font size is reset to default
+    size.clear();
+  }
+  insertChangedValue( QgsPalLayerSettings::Size, size );
 }
 
 void QgsLabelPropertyDialog::on_mBufferSizeSpinBox_valueChanged( double d )

diff --git a/src/ui/qgslabelpropertydialogbase.ui b/src/ui/qgslabelpropertydialogbase.ui
@@ -225,11 +225,20 @@
         </item>
         <item>
          <widget class="QgsDoubleSpinBox" name="mFontSizeSpinBox">
+          <property name="specialValueText">
+           <string>Default</string>
+          </property>
+          <property name="minimum">
+           <double>0.000000000000000</double>
+          </property>
           <property name="maximum">
            <double>999999.000000000000000</double>
           </property>
+          <property name="value">
+           <double>0.000000000000000</double>
+          </property>
           <property name="showClearButton">
-           <bool>false</bool>
+           <bool>true</bool>
           </property>
          </widget>
         </item>