Skip to content

Commit bb36fa7

Browse files
committedNov 7, 2017
[bugfix] Use QgsApplication.authManager()
instead of the old singleton
1 parent 7c9cd49 commit bb36fa7

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
 

‎python/pyplugin_installer/installer_data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
except ImportError:
4242
from imp import reload
4343
import qgis.utils
44-
from qgis.core import Qgis, QgsNetworkAccessManager, QgsAuthManager
44+
from qgis.core import Qgis, QgsNetworkAccessManager, QgsApplication
4545
from qgis.gui import QgsMessageBar
4646
from qgis.utils import iface, plugin_paths
4747
from .version_compare import compareVersions, normalizeVersion, isCompatible
@@ -333,7 +333,7 @@ def requestFetching(self, key):
333333
self.mRepositories[key]["QRequest"] = QNetworkRequest(url)
334334
authcfg = self.mRepositories[key]["authcfg"]
335335
if authcfg and isinstance(authcfg, str):
336-
if not QgsAuthManager.instance().updateNetworkRequest(
336+
if not QgsApplication.authManager().updateNetworkRequest(
337337
self.mRepositories[key]["QRequest"], authcfg.strip()):
338338
msg = QCoreApplication.translate(
339339
"QgsPluginInstaller",

‎python/pyplugin_installer/qgsplugininstallerinstallingdialog.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
from qgis.PyQt.QtNetwork import QNetworkRequest, QNetworkReply
3131

3232
import qgis
33-
from qgis.core import QgsNetworkAccessManager, QgsAuthManager
33+
from qgis.core import QgsNetworkAccessManager, QgsApplication
3434

3535
from .ui_qgsplugininstallerinstallingbase import Ui_QgsPluginInstallerInstallingDialogBase
3636
from .installer_data import removeDir, repositories
@@ -60,7 +60,7 @@ def __init__(self, parent, plugin):
6060
self.request = QNetworkRequest(url)
6161
authcfg = repositories.all()[plugin["zip_repository"]]["authcfg"]
6262
if authcfg and isinstance(authcfg, str):
63-
if not QgsAuthManager.instance().updateNetworkRequest(
63+
if not QgsApplication.authManager().updateNetworkRequest(
6464
self.request, authcfg.strip()):
6565
self.mResult = self.tr(
6666
"Update of network request with authentication "

0 commit comments

Comments
 (0)
Please sign in to comment.