[bugfix][DbManager] 14110 - Error fetching layer indexes with recent sqlite version

mdouchin · mdouchin · commit bae865153faa · 2016-01-19T10:27:52.000+01:00
Fixes #14110 The method `getTableIndexes`, situated in line 371 of the file `db_manager/db_plugins/spatialite/connector.py`, expected to get 3 fields from the sqlite method `PRAGMA index_list` . In recent versions of SQLite, since 3.8.9, though, this method now returns 5 fields. This commit fixes this issue by checking the length of columns returned by the method.
diff --git a/python/plugins/db_manager/db_plugins/spatialite/connector.py b/python/plugins/db_manager/db_plugins/spatialite/connector.py
@@ -368,7 +368,14 @@ def getTableIndexes(self, table):
         indexes = c.fetchall()
 
         for i, idx in enumerate(indexes):
-            num, name, unique = idx
+            # sqlite has changed the number of columns returned by index_list since 3.8.9
+            # I am not using self.getInfo() here because this behaviour
+            # can be changed back without notice as done for index_info, see:
+            # http://repo.or.cz/sqlite.git/commit/53555d6da78e52a430b1884b5971fef33e9ccca4
+            if len(idx) == 3:
+                num, name, unique = idx
+            if len(idx) == 5:
+                num, name, unique, createdby, partial = idx
             sql = u"PRAGMA index_info(%s)" % (self.quoteId(name))
             self._execute(c, sql)
 
