Refactor composer label test to work with svg, pdf and multi-resoluti…

…on classes - Initial (untested) svg and pdf render-to-image setup
qgis · Mar 6, 2014 · bad1898 · bad1898
1 parent 6a1b706
commit bad1898
Show file tree

Hide file tree

Showing 10 changed files with 205 additions and 58 deletions.
diff --git a/tests/src/python/test_qgspallabeling_composer.py b/tests/src/python/test_qgspallabeling_composer.py
@@ -22,15 +22,18 @@
 
 import sys
 import os
-import tempfile
+import subprocess
 from PyQt4.QtCore import *
 from PyQt4.QtGui import *
+from PyQt4.QtSvg import QSvgRenderer, QSvgGenerator
 
 from qgis.core import *
 
 from utilities import (
     unittest,
     expectedFailure,
+    getTempfilePath,
+    getExecutablePath,
 )
 
 from test_qgspallabeling_base import TestQgsPalLabeling, runSuite
@@ -39,46 +42,94 @@
     suiteTests
 )
 
+# look for Poppler, then muPDF PDF-to-image utility
+for util in ['pdftoppm', 'mudraw']:
+    PDFUTIL = getExecutablePath(util)
+    if PDFUTIL:
+        break
+
+
+def skip_if_not_pdf_util():  # skip test class decorator
+    if PDFUTIL:
+        return lambda func: func
+    return unittest.skip('\nPDF-to-image utility not found on PATH\n'
+                         'Install Poppler or muPDF utilities\n\n')
+
+
+# output kind enum
+# noinspection PyClassHasNoInit
+class OutputKind():
+    Img, Svg, Pdf = range(3)
+
 
 # noinspection PyShadowingNames
 class TestComposerBase(TestQgsPalLabeling):
 
+    layer = None
+    """:type: QgsVectorLayer"""
+
     @classmethod
     def setUpClass(cls):
-        TestQgsPalLabeling.setUpClass()
+        if not cls._BaseSetup:
+            TestQgsPalLabeling.setUpClass()
         # the blue background (set via layer style) to match renderchecker's
-        cls._BkgrdLayer = TestQgsPalLabeling.loadFeatureLayer('background')
+        TestQgsPalLabeling.loadFeatureLayer('background', True)
         cls._CheckMismatch = 0  # mismatch expected for crosscheck
-        cls._CheckGroup = ''
+        cls._TestImage = ''
+        cls._TestKind = ''  # img|svg|pdf
+        cls._ImgW = 600
+        cls._ImgH = 400
+        cls._ImgDpi = 72
 
     @classmethod
     def tearDownClass(cls):
         """Run after all tests"""
         TestQgsPalLabeling.tearDownClass()
+        cls._MapRegistry.removeMapLayer(cls.layer.id())
+        cls.layer = None
+
+    def setUp(self):
+        """Run before each test."""
+        TestQgsPalLabeling.setDefaultEngineSettings()
+        self.lyr = self.defaultLayerSettings()
+        self._TestImage = ''
 
-    def get_composer_image(self, width=600, height=400, dpi=72):
+    # noinspection PyUnusedLocal
+    def checkTest(self, **kwargs):
+        self.lyr.writeToLayer(self.layer)
+        res_m, self._TestImage = self.get_composer_output(self._TestKind)
+        self.saveContolImage(self._TestImage)
+        self.assertTrue(res_m, 'Failed to retrieve/save output from composer')
+        self.assertTrue(*self.renderCheck(mismatch=self._CheckMismatch,
+                                          imgpath=self._TestImage))
+
+    def _set_up_composition(self, width, height, dpi):
         # set up composition and add map
-        comp = QgsComposition(self._MapSettings)
+        # TODO: how to keep embedded map from being anti-aliased twice?
+        # self._MapSettings.setFlag(QgsMapSettings.Antialiasing, False)
+        self._c = QgsComposition(self._MapSettings)
         """:type: QgsComposition"""
-        comp.setPrintResolution(dpi)
+        self._c.setPrintResolution(dpi)
         # 600 x 400 px = 211.67 x 141.11 mm @ 72 dpi
         # TODO: figure out why this doesn't work and needs fudging
         #       probably need sets of fudgyness per dpi group (72, 150, 300)?
         paperw = round((width * 25.4 / dpi) + 0.05, 0)
         paperh = round((height * 25.4 / dpi) + 0.05, 1)
-        comp.setPaperSize(paperw, paperh)
-        compmap = QgsComposerMap(
-            comp, 0, 0, comp.paperWidth(), comp.paperHeight())
+        self._c.setPaperSize(paperw, paperh)
+        self._cmap = QgsComposerMap(
+            self._c, 0, 0, self._c.paperWidth(), self._c.paperHeight())
         """:type: QgsComposerMap"""
-        compmap.setFrameEnabled(False)
-        comp.addComposerMap(compmap)
-        compmap.setNewExtent(self.aoiExtent())
+        self._cmap.setFrameEnabled(False)
+        self._c.addComposerMap(self._cmap)
+        self._cmap.setNewExtent(self.aoiExtent())
+        self._c.setPlotStyle(QgsComposition.Print)
 
-        comp.setPlotStyle(QgsComposition.Print)
-        dpi = comp.printResolution()
+    # noinspection PyUnusedLocal
+    def _get_composer_image(self, width, height, dpi):
+        # dpi = self._c.printResolution()  # why did I add this before?
         dpmm = dpi / 25.4
-        img_width = int(dpmm * comp.paperWidth())
-        img_height = int(dpmm * comp.paperHeight())
+        img_width = int(dpmm * self._c.paperWidth())
+        img_height = int(dpmm * self._c.paperHeight())
 
         # create output image and initialize it
         image = QImage(QSize(img_width, img_height), QImage.Format_ARGB32)
@@ -88,77 +139,173 @@ def get_composer_image(self, width=600, height=400, dpi=72):
 
         # render the composition
         p = QPainter(image)
-        p.setRenderHint(QPainter.Antialiasing)
-        src = QRectF(0, 0, comp.paperWidth(), comp.paperHeight())
+        p.setRenderHint(QPainter.HighQualityAntialiasing, False)
+        p.setRenderHint(QPainter.SmoothPixmapTransform, False)
+        p.setRenderHint(QPainter.Antialiasing, False)
+        p.setRenderHint(QPainter.TextAntialiasing, False)
+        src = QRectF(0, 0, self._c.paperWidth(), self._c.paperHeight())
         trgt = QRectF(0, 0, img_width, img_height)
-        comp.render(p, trgt, src)
+        self._c.render(p, trgt, src)
         p.end()
 
-        tmp = tempfile.NamedTemporaryFile(suffix=".png", delete=False)
-        filepath = tmp.name
-        tmp.close()
+        filepath = getTempfilePath('png')
+        res = image.save(filepath, 'png')
+        if not res:
+            os.unlink(filepath)
+            filepath = ''
+
+        return res, filepath
 
-        res = image.save(filepath, "png")
+    def _get_composer_svg_image(self, width, height, dpi):
+        # from qgscomposer.cpp, QgsComposer::on_mActionExportAsSVG_triggered,
+        # line 1909, near end of function
+        svgpath = getTempfilePath('svg')
+        temp_size = os.path.getsize(svgpath)
+        svg_g = QSvgGenerator()
+        # noinspection PyArgumentList
+        svg_g.setTitle(QgsProject.instance().title())
+        svg_g.setFileName(svgpath)
+        # width and height in pixels
+        svg_w = int(self._c.paperWidth() * self._c.printResolution() / 25.4)
+        svg_h = int(self._c.paperHeight() * self._c.printResolution() / 25.4)
+        svg_g.setSize(QSize(svg_w, svg_h))
+        svg_g.setViewBox(QRect(0, 0, svg_w, svg_h))
+        # because the rendering is done in mm, convert the dpi
+        svg_g.setResolution(self._c.printResolution())
+
+        sp = QPainter(svg_g)
+        self._c.renderPage(sp, 0)
+        sp.end()
+
+        if temp_size == os.path.getsize(svgpath):
+            # something went pear-shaped
+            return False, ''
+
+        svgr = QSvgRenderer(svgpath)
+        image = QImage(width, height, QImage.Format_ARGB32)
+        image.fill(QColor(152, 219, 249).rgb())
+        image.setDotsPerMeterX(dpi/25.4 * 1000)
+        image.setDotsPerMeterY(dpi/25.4 * 1000)
+        p = QPainter(image)
+        svgr.render(p)
+        p.end()
+
+        filepath = getTempfilePath('png')
+        res = image.save(filepath, 'png')
         if not res:
             os.unlink(filepath)
             filepath = ''
+        # TODO: remove .svg file as well?
 
         return res, filepath
 
+    def _get_composer_pdf_image(self, width, height, dpi):
+        pdfpath = getTempfilePath('pdf')
+        temp_size = os.path.getsize(pdfpath)
+        p = QPrinter()
+        p.setOutputFormat(QPrinter.PdfFormat)
+        p.setOutputFileName(pdfpath)
+        p.setPaperSize(QSizeF(self._c.paperWidth(), self._c.paperHeight()),
+                       QPrinter.Millimeter)
+        p.setFullPage(True)
+        p.setColorMode(QPrinter.Color)
+        p.setResolution(self._c.printResolution())
+
+        pdf_p = QPainter(p)
+        page_mm = p.pageRect(QPrinter.Millimeter)
+        page_px = p.pageRect(QPrinter.DevicePixel)
+        self._c.render(pdf_p, page_px, page_mm)
+        pdf_p.end()
+
+        if temp_size == os.path.getsize(pdfpath):
+            # something went pear-shaped
+            return False, ''
+
+        filepath = getTempfilePath('png')
+        filebase = os.path.join(os.path.dirname(filepath),
+                                os.path.splitext(os.path.basename(filepath))[0])
+        # pdftoppm -singlefile -r 72 -x 0 -y 0 -W 600 -H 400 -png in.pdf pngbase
+        # mudraw -o out.png -r 72 -w 600 -h 400 -c rgb[a] in.pdf
+        if PDFUTIL == 'pdftoppm':
+            call = [
+                'pdftoppm', '-singlefile',
+                '-r', str(dpi),
+                '-x', str(0), '-y', str(0),
+                '-W', str(width), '-H', str(height),
+                '-png', pdfpath, filebase
+            ]
+        elif PDFUTIL == 'mudraw':
+            call = [
+                'mudraw'
+                '-o', filepath,
+                '-c', 'rgba',
+                '-r', str(dpi),
+                '-w', str(width), '-h', str(height),
+                pdfpath
+            ]
+        else:
+            return False, ''
 
-class TestComposerPoint(TestComposerBase, TestPointBase):
+        res = subprocess.check_call(call)
 
-    _TestImage = ''
+        if not res:
+            os.unlink(filepath)
+            filepath = ''
+
+        return res, filepath
+
+    def get_composer_output(self, kind):
+        width, height, dpi = self._ImgW, self._ImgH, self._ImgDpi
+        self._set_up_composition(width, height, dpi)
+        if kind == OutputKind.Svg:
+            return self._get_composer_svg_image(width, height, dpi)
+        elif kind == OutputKind.Pdf:
+            return self._get_composer_pdf_image(width, height, dpi)
+        else:  # 'img'
+            return self._get_composer_image(width, height, dpi)
+
+
+class TestComposerPointBase(TestComposerBase, TestPointBase):
 
     @classmethod
     def setUpClass(cls):
         TestComposerBase.setUpClass()
         cls.layer = TestQgsPalLabeling.loadFeatureLayer('point')
 
-    def setUp(self):
-        """Run before each test."""
-        self.configTest('pal_composer', 'sp')
-        TestQgsPalLabeling.setDefaultEngineSettings()
-        self.lyr = self.defaultSettings()
-        self._TestImage = ''
-
-    def tearDown(self):
-        """Run after each test."""
-        pass
 
-    def checkTest(self, **kwargs):
-        self.lyr.writeToLayer(self.layer)
-        res_m, self._TestImage = self.get_composer_image()
-        self.saveContolImage(self._TestImage)
-        self.assertTrue(res_m, 'Failed to retrieve/save image from test server')
-        # gp = kwargs['grpprefix'] if 'grpprefix' in kwargs else ''
-        self.assertTrue(*self.renderCheck(mismatch=self._CheckMismatch,
-                                          imgpath=self._TestImage,
-                                          grpprefix=self._CheckGroup))
+class TestComposerImagePoint(TestComposerPointBase):
 
+    def setUp(self):
+        """Run before each test."""
+        super(TestComposerImagePoint, self).setUp()
+        self._TestKind = OutputKind.Img
+        self.configTest('pal_composer', 'sp_img')
+        # TODO: due to double antialiasing?
+        self._CheckMismatch = 2700  # comment to PAL_REPORT difference
 
-class TestComposerVsCanvasPoint(TestComposerPoint):
 
-    @classmethod
-    def setUpClass(cls):
-        TestComposerPoint.setUpClass()
-        cls._CheckGroup = 'pal_canvas'
-        # rounding errors in composer; antialiasing?
-        cls._CheckMismatch = 2700
-        # cls._CheckMismatch = 0  # uncomment to PAL_REPORT actual difference
+class TestComposerImageVsCanvasPoint(TestComposerPointBase):
 
     def setUp(self):
-        super(TestComposerVsCanvasPoint, self).setUp()
+        """Run before each test."""
+        super(TestComposerImageVsCanvasPoint, self).setUp()
+        self._TestKind = OutputKind.Img
+        self.configTest('pal_canvas', 'sp')
+        # TODO: due to double antialiasing?
         if 'test_background_svg' in self.id():
             self._CheckMismatch = 3600
+            # self._CheckMismatch = 0  # uncomment to PAL_REPORT difference
 
 
 if __name__ == '__main__':
     # NOTE: unless PAL_SUITE env var is set all test class methods will be run
     # SEE: test_qgspallabeling_tests.suiteTests() to define suite
-    suite = (
-        ['TestComposerPoint.' + t for t in suiteTests()['sp_suite']] +
-        ['TestComposerVsCanvasPoint.' + t for t in suiteTests()['sp_vs_suite']]
-    )
+    st = suiteTests()
+    sp_i = ['TestComposerImagePoint.' + t for t in st['sp_suite']]
+    sp_ivs = ['TestComposerImageVsCanvasPoint.' + t for t in st['sp_vs_suite']]
+    suite = []
+    # extended separately for finer control of PAL_SUITE (comment-out undesired)
+    suite.extend(sp_i)
+    suite.extend(sp_ivs)
     res = runSuite(sys.modules[__name__], suite)
     sys.exit(not res.wasSuccessful())
diff --git a/...sp_background_rect/sp_background_rect.png → ...ackground_rect/sp_img_background_rect.png b/...sp_background_rect/sp_background_rect.png → ...ackground_rect/sp_img_background_rect.png
diff --git a/..._w_offset/sp_background_rect_w_offset.png → ...ffset/sp_img_background_rect_w_offset.png b/..._w_offset/sp_background_rect_w_offset.png → ...ffset/sp_img_background_rect_w_offset.png
diff --git a/...r/sp_background_svg/sp_background_svg.png → ..._background_svg/sp_img_background_svg.png b/...r/sp_background_svg/sp_background_svg.png → ..._background_svg/sp_img_background_svg.png
diff --git a/...g_w_offset/sp_background_svg_w_offset.png → ...offset/sp_img_background_svg_w_offset.png b/...g_w_offset/sp_background_svg_w_offset.png → ...offset/sp_img_background_svg_w_offset.png
diff --git a/...ser/sp_default_label/sp_default_label.png → ...mg_default_label/sp_img_default_label.png b/...ser/sp_default_label/sp_default_label.png → ...mg_default_label/sp_img_default_label.png
diff --git a/..._disabled/sp_partials_labels_disabled.png → ...abled/sp_img_partials_labels_disabled.png b/..._disabled/sp_partials_labels_disabled.png → ...abled/sp_img_partials_labels_disabled.png
diff --git a/...ls_enabled/sp_partials_labels_enabled.png → ...nabled/sp_img_partials_labels_enabled.png b/...ls_enabled/sp_partials_labels_enabled.png → ...nabled/sp_img_partials_labels_enabled.png
diff --git a/..._composer/sp_text_color/sp_text_color.png → ...r/sp_img_text_color/sp_img_text_color.png b/..._composer/sp_text_color/sp_text_color.png → ...r/sp_img_text_color/sp_img_text_color.png
diff --git a/...t_size_map_unit/sp_text_size_map_unit.png → ...ze_map_unit/sp_img_text_size_map_unit.png b/...t_size_map_unit/sp_text_size_map_unit.png → ...ze_map_unit/sp_img_text_size_map_unit.png