Toggle bool variable

qgis · Aug 5, 2021 · baa9062 · baa9062
1 parent 974c55e
commit baa9062
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -10963,12 +10963,13 @@ void QgisApp::toggleEditing()
   const QList<QgsMapLayer *> layerList = layerTreeView()->selectedLayers();
   if ( !layerList.isEmpty() )
   {
-    // if there are selected layers, try to toggle those
-    const bool shouldStartEditing = !mActionToggleEditing->isChecked();
+    // if there are selected layers, try to toggle those.
+    // mActionToggleEditing has already been triggered at this point so its checked status has changed
+    const bool shouldStartEditing = mActionToggleEditing->isChecked();
     for ( const auto layer : layerList )
     {
       if ( layer->supportsEditing() &&
-           shouldStartEditing == layer->isEditable() )
+           shouldStartEditing != layer->isEditable() )
       {
         toggleEditing( layer, true );
       }