[o2] A new refresh_token is not a mandatory part of the response

nyalldawson · nyalldawson · commit ba8f8e3f073a · 2019-05-12T15:00:25.000+10:00
after requesting a refresh

The server will always return a new access_token, but returning
a new refresh_token is optional
diff --git a/external/o2/src/o2.cpp b/external/o2/src/o2.cpp
@@ -437,7 +437,9 @@ void O2::onRefreshFinished() {
         QVariantMap tokens = parseTokenResponse(reply);
         setToken(tokens.value(O2_OAUTH2_ACCESS_TOKEN).toString());
         setExpires(QDateTime::currentMSecsSinceEpoch() / 1000 + tokens.value(O2_OAUTH2_EXPIRES_IN).toInt());
-        setRefreshToken(tokens.value(O2_OAUTH2_REFRESH_TOKEN).toString());
+        const QString refreshToken = tokens.value(O2_OAUTH2_REFRESH_TOKEN).toString();
+        if ( !refreshToken.isEmpty() )
+          setRefreshToken(refreshToken);
         timedReplies_.remove(refreshReply);
         setLinked(true);
         Q_EMIT linkingSucceeded();
