[server] Safety measure to prevent potential leaks

elpaso · elpaso · commit b97e86da4132 · 2016-02-23T10:47:12.000+01:00
diff --git a/src/server/qgshttprequesthandler.cpp b/src/server/qgshttprequesthandler.cpp
@@ -456,6 +456,8 @@ void QgsHttpRequestHandler::setGetFeatureInfoResponse( const QDomDocument& infoD
 
 void QgsHttpRequestHandler::setServiceException( QgsMapServiceException ex )
 {
+  // Safety measure to avoid potential leaks if called repeatedly
+  delete mException;
   mException = new QgsMapServiceException( ex );
   //create Exception DOM document
   QDomDocument exceptionDoc;

Original file line number	Diff line number	Diff line change
`@@ -456,6 +456,8 @@ void QgsHttpRequestHandler::setGetFeatureInfoResponse( const QDomDocument& infoD`
`456`	`456`
`457`	`457`	`void QgsHttpRequestHandler::setServiceException( QgsMapServiceException ex )`
`458`	`458`	`{`
	`459`	`+ // Safety measure to avoid potential leaks if called repeatedly`
	`460`	`+ delete mException;`
`459`	`461`	`mException = new QgsMapServiceException( ex );`
`460`	`462`	`//create Exception DOM document`
`461`	`463`	`QDomDocument exceptionDoc;`