Apply suggestions from code review

Co-Authored-By: Matthias Kuhn <matthias@opengis.ch>
qgis · Apr 30, 2020 · b97543d · b97543d
1 parent fc3bb46
commit b97543d
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/scripts/rename_cpp.sh b/scripts/rename_cpp.sh
@@ -1,5 +1,10 @@
 #!/usr/bin/env bash
 
+# This scripts renames the name of a class as well as its header and cpp file
+# (assuming they are the lowercase version of the class name).
+# 
+# Usage: ./scripts/rename_cpp.sh src/core QgsMyClassName QgsMyNewClassName
+
 set -e
 
 # GNU prefix command for mac os support (gsed, gsplit)

diff --git a/src/core/qgsfeatureexpressionvaluesgatherer.h b/src/core/qgsfeatureexpressionvaluesgatherer.h
@@ -31,7 +31,7 @@
  * \class QgsFieldExpressionValuesGatherer
  * Gathers features with substring matching on an expression.
  *
- * \since QGIS 3.0
+ * \since QGIS 3.14
  */
 class QgsFeatureExpressionValuesGatherer: public QThread
 {

diff --git a/src/core/qgsfeaturefiltermodel.h b/src/core/qgsfeaturefiltermodel.h
@@ -30,14 +30,14 @@ class CORE_EXPORT QgsFeatureFilterModel : public QgsFeaturePickerModelBase
     Q_OBJECT
 
     /**
-     * A field of sourceLayer that is unique and should be used to identify features.
+     * A set of fields of sourceLayer that is unique and should be used to identify features.
      * Normally the primary key field.
      * Needs to match the identifierValue.
      */
     Q_PROPERTY( QStringList identifierFields READ identifierFields WRITE setIdentifierFields NOTIFY identifierFieldsChanged )
 
     /**
-     * The value that identifies the current feature.
+     * The values that identifies the current feature.
      */
     Q_PROPERTY( QVariantList extraIdentifierValues READ extraIdentifierValues WRITE setExtraIdentifierValues NOTIFY extraIdentifierValuesChanged )
 

diff --git a/src/gui/qgsexpressionpreviewwidget.cpp b/src/gui/qgsexpressionpreviewwidget.cpp
@@ -121,10 +121,10 @@ void QgsExpressionPreviewWidget::refreshPreview()
 
 void QgsExpressionPreviewWidget::linkActivated( const QString & )
 {
-  QgsMessageViewer *mv = new QgsMessageViewer( this );
-  mv->setWindowTitle( tr( "More Info on Expression Error" ) );
-  mv->setMessageAsHtml( mToolTip );
-  mv->exec();
+  QgsMessageViewer mv( this );
+  mv.setWindowTitle( tr( "More Info on Expression Error" ) );
+  mv.setMessageAsHtml( mToolTip );
+  mv.exec();
 }
 
 void QgsExpressionPreviewWidget::setExpressionToolTip( const QString &toolTip )
@@ -163,4 +163,3 @@ bool QgsExpressionPreviewWidget::evalError() const
 {
   return mEvalError;
 }
-