Apply suggestions from code review

3nids · m-kuhn · web-flow · commit b97543d9ccb6 · 2020-04-30T06:43:55.000+02:00
Co-Authored-By: Matthias Kuhn &lt;matthias@opengis.ch&gt;
diff --git a/scripts/rename_cpp.sh b/scripts/rename_cpp.sh
@@ -1,5 +1,10 @@
 #!/usr/bin/env bash
 
+# This scripts renames the name of a class as well as its header and cpp file
+# (assuming they are the lowercase version of the class name).
+# 
+# Usage: ./scripts/rename_cpp.sh src/core QgsMyClassName QgsMyNewClassName
+
 set -e
 
 # GNU prefix command for mac os support (gsed, gsplit)
diff --git a/src/core/qgsfeatureexpressionvaluesgatherer.h b/src/core/qgsfeatureexpressionvaluesgatherer.h
@@ -31,7 +31,7 @@
  * \class QgsFieldExpressionValuesGatherer
  * Gathers features with substring matching on an expression.
  *
- * \since QGIS 3.0
+ * \since QGIS 3.14
  */
 class QgsFeatureExpressionValuesGatherer: public QThread
 {
diff --git a/src/core/qgsfeaturefiltermodel.h b/src/core/qgsfeaturefiltermodel.h
@@ -30,14 +30,14 @@ class CORE_EXPORT QgsFeatureFilterModel : public QgsFeaturePickerModelBase
     Q_OBJECT
 
     /**
-     * A field of sourceLayer that is unique and should be used to identify features.
+     * A set of fields of sourceLayer that is unique and should be used to identify features.
      * Normally the primary key field.
      * Needs to match the identifierValue.
      */
     Q_PROPERTY( QStringList identifierFields READ identifierFields WRITE setIdentifierFields NOTIFY identifierFieldsChanged )
 
     /**
-     * The value that identifies the current feature.
+     * The values that identifies the current feature.
      */
     Q_PROPERTY( QVariantList extraIdentifierValues READ extraIdentifierValues WRITE setExtraIdentifierValues NOTIFY extraIdentifierValuesChanged )
 
diff --git a/src/gui/qgsexpressionpreviewwidget.cpp b/src/gui/qgsexpressionpreviewwidget.cpp
@@ -121,10 +121,10 @@ void QgsExpressionPreviewWidget::refreshPreview()
 
 void QgsExpressionPreviewWidget::linkActivated( const QString & )
 {
-  QgsMessageViewer *mv = new QgsMessageViewer( this );
-  mv->setWindowTitle( tr( "More Info on Expression Error" ) );
-  mv->setMessageAsHtml( mToolTip );
-  mv->exec();
+  QgsMessageViewer mv( this );
+  mv.setWindowTitle( tr( "More Info on Expression Error" ) );
+  mv.setMessageAsHtml( mToolTip );
+  mv.exec();
 }
 
 void QgsExpressionPreviewWidget::setExpressionToolTip( const QString &toolTip )
@@ -163,4 +163,3 @@ bool QgsExpressionPreviewWidget::evalError() const
 {
   return mEvalError;
 }
-

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`* \class QgsFieldExpressionValuesGatherer`
`32`	`32`	`* Gathers features with substring matching on an expression.`
`33`	`33`	`*`
`34`		`- * \since QGIS 3.0`
	`34`	`+ * \since QGIS 3.14`
`35`	`35`	`*/`
`36`	`36`	`class QgsFeatureExpressionValuesGatherer: public QThread`
`37`	`37`	`{`
Original file line number	Diff line number	Diff line change
`@@ -121,10 +121,10 @@ void QgsExpressionPreviewWidget::refreshPreview()`
`121`	`121`
`122`	`122`	`void QgsExpressionPreviewWidget::linkActivated( const QString & )`
`123`	`123`	`{`
`124`		`- QgsMessageViewer *mv = new QgsMessageViewer( this );`
`125`		`- mv->setWindowTitle( tr( "More Info on Expression Error" ) );`
`126`		`- mv->setMessageAsHtml( mToolTip );`
`127`		`- mv->exec();`
	`124`	`+ QgsMessageViewer mv( this );`
	`125`	`+ mv.setWindowTitle( tr( "More Info on Expression Error" ) );`
	`126`	`+ mv.setMessageAsHtml( mToolTip );`
	`127`	`+ mv.exec();`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`void QgsExpressionPreviewWidget::setExpressionToolTip( const QString &toolTip )`
`@@ -163,4 +163,3 @@ bool QgsExpressionPreviewWidget::evalError() const`
`163`	`163`	`{`
`164`	`164`	`return mEvalError;`
`165`	`165`	`}`
`166`		`-`