QgsVectorDataProvider::supportedType(): only checks field length and precision against min/max if they are defined (ie > 0). Fixes test_qgsauxiliarystorage.py and qgis_projectstoragetest

rouault · rouault · commit b9003ffa12b2 · 2018-06-01T14:06:04.000+02:00
diff --git a/src/core/qgsvectordataprovider.cpp b/src/core/qgsvectordataprovider.cpp
@@ -343,16 +343,7 @@ bool QgsVectorDataProvider::supportedType( const QgsField &field ) const
     if ( field.type() != nativeType.mType )
       continue;
 
-    if ( field.length() <= 0 )
-    {
-      // source length unlimited
-      if ( nativeType.mMinLen > 0 || nativeType.mMaxLen > 0 )
-      {
-        // destination limited
-        continue;
-      }
-    }
-    else
+    if ( field.length() > 0 )
     {
       // source length limited
       if ( ( nativeType.mMinLen > 0 && field.length() < nativeType.mMinLen ) ||
@@ -363,18 +354,9 @@ bool QgsVectorDataProvider::supportedType( const QgsField &field ) const
       }
     }
 
-    if ( field.precision() <= 0 )
-    {
-      // source precision unlimited / n/a
-      if ( nativeType.mMinPrec > 0 || nativeType.mMaxPrec > 0 )
-      {
-        // destination limited
-        continue;
-      }
-    }
-    else
+    if ( field.precision() > 0 )
     {
-      // source precision unlimited / n/a
+      // source precision limited
       if ( ( nativeType.mMinPrec > 0 && field.precision() < nativeType.mMinPrec ) ||
            ( nativeType.mMaxPrec > 0 && field.precision() > nativeType.mMaxPrec ) )
       {
