fix #17456 improve CRS display in the metadata tab

Gustry · Gustry · commit b895b74303ff · 2017-11-21T17:00:21.000+01:00
diff --git a/src/core/metadata/qgslayermetadataformatter.cpp b/src/core/metadata/qgslayermetadataformatter.cpp
@@ -96,12 +96,16 @@ QString QgsLayerMetadataFormatter::contactsSectionHtml() const
 QString QgsLayerMetadataFormatter::extentSectionHtml() const
 {
   QString myMetadata = QStringLiteral( "<table class=\"list-view\">\n" );
-  myMetadata += QStringLiteral( "<tr><td class=\"highlight\">" ) + QObject::tr( "CRS" ) + QStringLiteral( "</td><td>" ) + mMetadata.crs().authid() + QStringLiteral( " - " );
-  myMetadata += mMetadata.crs().description() + QStringLiteral( " - " );
-  if ( mMetadata.crs().isGeographic() )
-    myMetadata += QObject::tr( "Geographic" );
-  else
-    myMetadata += QObject::tr( "Projected" );
+  myMetadata += QStringLiteral( "<tr><td class=\"highlight\">" ) + QObject::tr( "CRS" ) + QStringLiteral( "</td><td>" );
+  if ( mMetadata.crs().isValid() )
+  {
+    myMetadata += mMetadata.crs().authid() + QStringLiteral( " - " );
+    myMetadata += mMetadata.crs().description() + QStringLiteral( " - " );
+    if ( mMetadata.crs().isGeographic() )
+      myMetadata += QObject::tr( "Geographic" );
+    else
+      myMetadata += QObject::tr( "Projected" );
+  }
   myMetadata += QLatin1String( "</td></tr>\n" );
 
   const QgsLayerMetadata::Extent extent = mMetadata.extent();
diff --git a/src/gui/qgsmetadatawidget.cpp b/src/gui/qgsmetadatawidget.cpp
@@ -414,6 +414,10 @@ void QgsMetadataWidget::setPropertiesFromLayer() const
   {
     selectionCrs->setCrs( mMetadata.crs() );
   }
+  else
+  {
+    selectionCrs->setOptionVisible( QgsProjectionSelectionWidget::CrsNotSet, true );
+  }
 
   // Links
   const QList<QgsLayerMetadata::Link> &links = mMetadata.links();

Original file line number	Diff line number	Diff line change
`@@ -414,6 +414,10 @@ void QgsMetadataWidget::setPropertiesFromLayer() const`
`414`	`414`	`{`
`415`	`415`	`selectionCrs->setCrs( mMetadata.crs() );`
`416`	`416`	`}`
	`417`	`+ else`
	`418`	`+ {`
	`419`	`+ selectionCrs->setOptionVisible( QgsProjectionSelectionWidget::CrsNotSet, true );`
	`420`	`+ }`
`417`	`421`
`418`	`422`	`// Links`
`419`	`423`	`const QList<QgsLayerMetadata::Link> &links = mMetadata.links();`