[db manager] Fix virtual layer uid handling

Hugo Mercier · Hugo Mercier · commit b7fa5400b67c · 2016-11-22T16:09:53.000+01:00
diff --git a/python/plugins/db_manager/db_plugins/vlayers/plugin.py b/python/plugins/db_manager/db_plugins/vlayers/plugin.py
@@ -24,7 +24,7 @@
 
 from qgis.PyQt.QtCore import QUrl
 from qgis.PyQt.QtGui import QIcon
-from qgis.core import QgsVectorLayer, QgsMapLayerRegistry
+from qgis.core import QgsVectorLayer, QgsMapLayerRegistry, QgsVirtualLayerDefinition
 
 from ..plugin import DBPlugin, Database, Table, VectorTable, TableField
 
@@ -100,13 +100,14 @@ def sqlResultModel(self, sql, parent):
         return LSqlResultModel(self, sql, parent)
 
     def toSqlLayer(self, sql, geomCol, uniqueCol, layerName="QueryLayer", layerType=None, avoidSelectById=False, _filter=""):
-        q = QUrl.toPercentEncoding(sql)
-        s = "?query=%s" % q
+        df = QgsVirtualLayerDefinition()
+        df.setQuery(sql)
         if uniqueCol is not None:
-            s += "&uid=" + uniqueCol
+            uniqueCol = uniqueCol.strip('"').replace('""', '"')
+            df.setUid(uniqueCol)
         if geomCol is not None:
-            s += "&geometry=" + geomCol
-        vl = QgsVectorLayer(s, layerName, "virtual")
+            df.setGeometryField(geomCol)
+        vl = QgsVectorLayer(df.toString(), layerName, "virtual")
         if _filter:
             vl.setSubsetString(_filter)
         return vl
