Fix point picking precision for point parameters in processing dialog

troopa81 · troopa81 · commit b7772d407d9c · 2019-04-26T15:38:51.000+02:00
diff --git a/src/gui/processing/qgsprocessingwidgetwrapperimpl.cpp b/src/gui/processing/qgsprocessingwidgetwrapperimpl.cpp
@@ -2205,7 +2205,10 @@ void QgsProcessingPointPanel::clear()
 
 void QgsProcessingPointPanel::setValue( const QgsPointXY &point, const QgsCoordinateReferenceSystem &crs )
 {
-  QString newText = QStringLiteral( "%1,%2" ).arg( point.x() ).arg( point.y() );
+  QString newText = QStringLiteral( "%1,%2" )
+                    .arg( QString::number( point.x(), 'g', 18 ) )
+                    .arg( QString::number( point.y(), 'g', 18 ) );
+
   mCrs = crs;
   if ( mCrs.isValid() )
   {
diff --git a/tests/src/gui/testprocessinggui.cpp b/tests/src/gui/testprocessinggui.cpp
@@ -2841,19 +2841,23 @@ void TestProcessingGui::testPointPanel()
   QCOMPARE( panel->value().toString(), QStringLiteral( "200,250 [EPSG:3111]" ) );
   QCOMPARE( spy.count(), 2 );
 
+  panel->setValue( QgsPointXY( 123456.123456789122, 654321.987654321012 ), QgsCoordinateReferenceSystem() );
+  QCOMPARE( panel->value().toString(), QStringLiteral( "123456.123456789122,654321.987654321012" ) );
+  QCOMPARE( spy.count(), 3 );
+
   QVERIFY( !panel->mLineEdit->showClearButton() );
   panel->setAllowNull( true );
   QVERIFY( panel->mLineEdit->showClearButton() );
   panel->clear();
   QVERIFY( !panel->value().isValid() );
-  QCOMPARE( spy.count(), 3 );
+  QCOMPARE( spy.count(), 4 );
 
   QgsMapCanvas canvas;
   canvas.setDestinationCrs( QgsCoordinateReferenceSystem( QStringLiteral( "EPSG:28356" ) ) );
   panel->setMapCanvas( &canvas );
   panel->updatePoint( QgsPointXY( 1.5, -3.5 ) );
   QCOMPARE( panel->value().toString(), QStringLiteral( "1.5,-3.5 [EPSG:28356]" ) );
-  QCOMPARE( spy.count(), 4 );
+  QCOMPARE( spy.count(), 5 );
 
   panel.reset();
 }

Original file line number	Diff line number	Diff line change
`@@ -2205,7 +2205,10 @@ void QgsProcessingPointPanel::clear()`
`2205`	`2205`
`2206`	`2206`	`void QgsProcessingPointPanel::setValue( const QgsPointXY &point, const QgsCoordinateReferenceSystem &crs )`
`2207`	`2207`	`{`
`2208`		`- QString newText = QStringLiteral( "%1,%2" ).arg( point.x() ).arg( point.y() );`
	`2208`	`+ QString newText = QStringLiteral( "%1,%2" )`
	`2209`	`+ .arg( QString::number( point.x(), 'g', 18 ) )`
	`2210`	`+ .arg( QString::number( point.y(), 'g', 18 ) );`
	`2211`	`+`
`2209`	`2212`	`mCrs = crs;`
`2210`	`2213`	`if ( mCrs.isValid() )`
`2211`	`2214`	`{`