Bug fix and gui enhancement:

timlinux · timlinux · commit b6ee23c0a824 · 2008-05-14T12:57:40.000Z
- remove rendering artifacts in legend item icons (dont use argb premultified!) - show polygon icons as a squiggly polygon so the edges arent clipped (and hopefull people find it more attractive) - show line icons as a curve git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@8430 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/app/legend/qgslegenditem.cpp b/src/app/legend/qgslegenditem.cpp
@@ -20,7 +20,6 @@
 #include "qgslegenditem.h"
 #include <iostream>
 #include <QCoreApplication>
-#include <QIcon>
 #include "qgslegend.h"
 
 
diff --git a/src/app/legend/qgslegendsymbologyitem.cpp b/src/app/legend/qgslegendsymbologyitem.cpp
@@ -21,12 +21,19 @@
 #include "qgslegendsymbologyitem.h"
 
 QgsLegendSymbologyItem::QgsLegendSymbologyItem(QTreeWidgetItem * theItem,QString theString, int pixmapWidth, int pixmapHeight)
-  : QgsLegendItem(theItem, theString), mPixmapWidth(pixmapWidth), mPixmapHeight(pixmapHeight), mLegend(0)
+  : QgsLegendItem(theItem, theString), 
+    mPixmapWidth(pixmapWidth), 
+    mPixmapHeight(pixmapHeight), 
+    mLegend(0)
 {
   mType = LEGEND_SYMBOL_ITEM;
 }
 
-QgsLegendSymbologyItem::QgsLegendSymbologyItem(int pixmapWidth, int pixmapHeight): QgsLegendItem(), mPixmapWidth(pixmapWidth), mPixmapHeight(pixmapHeight), mLegend(0)
+QgsLegendSymbologyItem::QgsLegendSymbologyItem(int pixmapWidth, int pixmapHeight)
+ : QgsLegendItem(), 
+   mPixmapWidth(pixmapWidth), 
+   mPixmapHeight(pixmapHeight), 
+   mLegend(0)
 {
   mType = LEGEND_SYMBOL_ITEM;
 }
diff --git a/src/core/symbology/qgssymbol.cpp b/src/core/symbology/qgssymbol.cpp
@@ -245,23 +245,60 @@ int QgsSymbol::pointSize() const
 
 QImage QgsSymbol::getLineSymbolAsImage()
 {
-    QImage img(15, 15, QImage::Format_ARGB32_Premultiplied);
-    img.fill(QColor(255,255,255,0).rgba());
-    QPainter p(&img);
-    p.setPen(mPen);
-    p.drawLine(0, 0, 15, 15);
-    return img; //this is ok because of qts sharing mechanism
+  //Note by Tim: dont use premultiplied - it causes
+  //artifacts on the output icon!
+  QImage img(15, 15,QImage::Format_ARGB32 );//QImage::Format_ARGB32_Premultiplied);
+  img.fill(QColor(255,255,255,255).rgba());
+  QPainter p(&img);
+  p.setRenderHints(QPainter::Antialiasing);
+  p.setPen(mPen);
+
+
+  QPainterPath myPath;
+  myPath.moveTo(0, 0);
+  myPath.cubicTo(15, 0, 5, 7, 15, 15);
+  p.drawPath(myPath);
+  //p.drawLine(0, 0, 15, 15);
+  return img; //this is ok because of qts sharing mechanism
 }
 
 QImage QgsSymbol::getPolygonSymbolAsImage()
 {
-   QImage img(15, 15, QImage::Format_ARGB32_Premultiplied);
-   img.fill(QColor(255,255,255,0).rgba());
-   QPainter p(&img);
-   p.setPen(mPen);
-   p.setBrush(mBrush);
-   p.drawRect(0, 0, 15, 15);
-   return img; //this is ok because of qts sharing mechanism 
+  //Note by Tim: dont use premultiplied - it causes
+  //artifacts on the output icon!
+  QImage img(15, 15,QImage::Format_ARGB32); //, QImage::Format_ARGB32_Premultiplied);
+  img.fill(QColor(255,255,255,255).rgba());
+  QPainter p(&img);
+  p.setRenderHints(QPainter::Antialiasing);
+  p.setPen(mPen);
+  p.setBrush(mBrush);
+  QPolygon myPolygon; 
+  //leave a little white space around so
+  //dont draw at 0,0,15,15 
+  myPolygon << QPoint(2, 2)
+    << QPoint(1, 5)
+    << QPoint(1, 10)
+    << QPoint(2, 12)
+    << QPoint(5, 13)
+    << QPoint(6, 13) 
+    << QPoint(8, 12)
+    << QPoint(8, 12)
+    << QPoint(10, 12)
+    << QPoint(12, 13)
+    << QPoint(13, 11)
+    << QPoint(12, 8)
+    << QPoint(11, 6)
+    << QPoint(12, 5) 
+    << QPoint(13, 2)
+    << QPoint(11, 1)
+    << QPoint(10, 1)
+    << QPoint(8, 2)
+    << QPoint(6, 4)
+    << QPoint(4, 2)
+    ;
+  p.drawPolygon(myPolygon); 
+  //p.drawRect(1, 1, 14, 14); 
+  return img; //this is ok because of qts sharing mechanism 
 }
 
 QImage QgsSymbol::getCachedPointSymbolAsImage(  double widthScale,

Original file line number	Diff line number	Diff line change
`@@ -21,12 +21,19 @@`
`21`	`21`	`#include "qgslegendsymbologyitem.h"`
`22`	`22`
`23`	`23`	`QgsLegendSymbologyItem::QgsLegendSymbologyItem(QTreeWidgetItem * theItem,QString theString, int pixmapWidth, int pixmapHeight)`
`24`		`- : QgsLegendItem(theItem, theString), mPixmapWidth(pixmapWidth), mPixmapHeight(pixmapHeight), mLegend(0)`
	`24`	`+ : QgsLegendItem(theItem, theString),`
	`25`	`+ mPixmapWidth(pixmapWidth),`
	`26`	`+ mPixmapHeight(pixmapHeight),`
	`27`	`+ mLegend(0)`
`25`	`28`	`{`
`26`	`29`	`mType = LEGEND_SYMBOL_ITEM;`
`27`	`30`	`}`
`28`	`31`
`29`		`-QgsLegendSymbologyItem::QgsLegendSymbologyItem(int pixmapWidth, int pixmapHeight): QgsLegendItem(), mPixmapWidth(pixmapWidth), mPixmapHeight(pixmapHeight), mLegend(0)`
	`32`	`+QgsLegendSymbologyItem::QgsLegendSymbologyItem(int pixmapWidth, int pixmapHeight)`
	`33`	`+ : QgsLegendItem(),`
	`34`	`+ mPixmapWidth(pixmapWidth),`
	`35`	`+ mPixmapHeight(pixmapHeight),`
	`36`	`+ mLegend(0)`
`30`	`37`	`{`
`31`	`38`	`mType = LEGEND_SYMBOL_ITEM;`
`32`	`39`	`}`