Fix crash on exit

Because the map canvas is destroyed before the project instance, and QgsProject emits the labelingEngineSettingsChange signal during its destructor, the lambda slot was getting executed with a dangling map canvas pointer. Correctly set the receiver in the lambda connection instead so that the connection gets destroyed along with the canvas.
qgis · May 1, 2018 · b683291 · b683291
1 parent 46f867c
commit b683291
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -3253,7 +3253,7 @@ void QgisApp::setupConnections()
   } );
 
   connect( QgsProject::instance(), &QgsProject::labelingEngineSettingsChanged,
-           this, [ = ]
+           mMapCanvas, [ = ]
   {
     mMapCanvas->setLabelingEngineSettings( QgsProject::instance()->labelingEngineSettings() );
   } );