Show warning, more efficient map iteration

qgis · Jan 29, 2021 · b65339c · b65339c
1 parent e4a4b83
commit b65339c
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/server/services/landingpage/qgslandingpagehandlers.cpp b/src/server/services/landingpage/qgslandingpagehandlers.cpp
@@ -65,17 +65,16 @@ const QString QgsLandingPageHandler::templatePath( const QgsServerApiContext &co
 json QgsLandingPageHandler::projectsData() const
 {
   json j = json::array();
-  const auto availableProjects { QgsLandingPageUtils::projects( *mSettings ) };
-  const auto constProjectKeys { availableProjects.keys() };
-  for ( const auto &p : constProjectKeys )
+  const QMap<QString, QString> availableProjects = QgsLandingPageUtils::projects( *mSettings );
+  for ( auto it = availableProjects.constBegin(); it != availableProjects.constEnd(); ++it )
   {
     try
     {
-      j.push_back( QgsLandingPageUtils::projectInfo( availableProjects[ p ] ) );
+      j.push_back( QgsLandingPageUtils::projectInfo( it.value() ) );
     }
     catch ( QgsServerException & )
     {
-      // skip broken projects!
+      QgsMessageLog::logMessage( QStringLiteral( "Could not open project '%1': skipping." ).arg( it.value() ), QStringLiteral( "Landing Page" ), Qgis::MessageLevel::Critical );
     }
   }
   return j;