Skip to content

Commit

Permalink
fix windows build (followup dd40a3d)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jef-n
jef-n committed May 24, 2017
1 parent dd40a3d commit b3f2fe2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/qgsfeatureiterator.h
View file
Expand Up @@ -180,7 +180,7 @@ class CORE_EXPORT QgsAbstractFeatureIterator
* \note not available in Python bindings (although present in SIP file)
*/
template<typename T>
class QgsAbstractFeatureIteratorFromSource : public QgsAbstractFeatureIterator
class CORE_EXPORT QgsAbstractFeatureIteratorFromSource : public QgsAbstractFeatureIterator
{
public:
QgsAbstractFeatureIteratorFromSource( T *source, bool ownSource, const QgsFeatureRequest &request )
Expand Down

3 comments on commit b3f2fe2

@3nids
Copy link
Member

@3nids 3nids commented on b3f2fe2 May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone wants windows CI ????

@nyalldawson
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n Does this really fix the Windows builds for you? For me I have to remove this CORE_EXPORT or I can't get the build to work in windows:

error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall QgsAbstractFeatureIteratorFromSource<class QgsGPXFeatureSource>::QgsAbstractFeatureIteratorFromSource<class QgsGPXFeatureSource>(class QgsGPXFeatureSource *,bool,class QgsFeatureRequest const &)" (__imp_??0?$QgsAbstractFeatureIteratorFromSource@VQgsGPXFeatureSource@@@@QAE@PAVQgsGPXFeatureSource@@_NABVQgsFeatureRequest@@@Z) referenced in function "public: __thiscall QgsGPXFeatureIterator::QgsGPXFeatureIterator(class QgsGPXFeatureSource *,bool,class QgsFeatureRequest const &)" (??0QgsGPXFeatureIterator@@QAE@PAVQgsGPXFeatureSource@@_NABVQgsFeatureRequest@@@Z

Removing the CORE_EXPORT fixes the build.

@jef-n
Copy link
Member Author

@jef-n jef-n commented on b3f2fe2 May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - as said it doesn't. Did you add it for the nightly and remove it again afterwards?

Please sign in to comment.