Skip to content

Commit b3f2fe2

Browse files
jef-njef-n
committedMay 24, 2017
fix windows build (followup dd40a3d)
·
ltr-3_40final-3_0_0
1 parent dd40a3d commit b3f2fe2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎src/core/qgsfeatureiterator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ class CORE_EXPORT QgsAbstractFeatureIterator
180180
* \note not available in Python bindings (although present in SIP file)
181181
*/
182182
template<typename T>
183-
class QgsAbstractFeatureIteratorFromSource : public QgsAbstractFeatureIterator
183+
class CORE_EXPORT QgsAbstractFeatureIteratorFromSource : public QgsAbstractFeatureIterator
184184
{
185185
public:
186186
QgsAbstractFeatureIteratorFromSource( T *source, bool ownSource, const QgsFeatureRequest &request )

3 commit comments

Comments
 (3)

3nids commented on May 24, 2017

@3nids
3nids
on May 24, 2017
Member

someone wants windows CI ????

nyalldawson commented on May 24, 2017

@nyalldawson
nyalldawson
on May 24, 2017
Collaborator

@jef-n Does this really fix the Windows builds for you? For me I have to remove this CORE_EXPORT or I can't get the build to work in windows:

error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall QgsAbstractFeatureIteratorFromSource<class QgsGPXFeatureSource>::QgsAbstractFeatureIteratorFromSource<class QgsGPXFeatureSource>(class QgsGPXFeatureSource *,bool,class QgsFeatureRequest const &)" (__imp_??0?$QgsAbstractFeatureIteratorFromSource@VQgsGPXFeatureSource@@@@QAE@PAVQgsGPXFeatureSource@@_NABVQgsFeatureRequest@@@Z) referenced in function "public: __thiscall QgsGPXFeatureIterator::QgsGPXFeatureIterator(class QgsGPXFeatureSource *,bool,class QgsFeatureRequest const &)" (??0QgsGPXFeatureIterator@@QAE@PAVQgsGPXFeatureSource@@_NABVQgsFeatureRequest@@@Z

Removing the CORE_EXPORT fixes the build.

jef-n commented on May 24, 2017

@jef-n
jef-n
on May 24, 2017
MemberAuthor

No - as said it doesn't. Did you add it for the nightly and remove it again afterwards?

Please sign in to comment.