Skip to content

Commit

Permalink
Swap remaining QSharedPointer uses to std::shared_ptr
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Jun 20, 2017
1 parent 61a4610 commit b3da171
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 14 deletions.
4 changes: 2 additions & 2 deletions src/providers/arcgisrest/qgsafsfeatureiterator.cpp
Expand Up @@ -19,7 +19,7 @@
#include "geometry/qgsgeometry.h"
#include "qgscsexception.h"

QgsAfsFeatureSource::QgsAfsFeatureSource( const QSharedPointer<QgsAfsSharedData> &sharedData )
QgsAfsFeatureSource::QgsAfsFeatureSource( const std::shared_ptr<QgsAfsSharedData> &sharedData )
: mSharedData( sharedData )
{
}
Expand All @@ -31,7 +31,7 @@ QgsFeatureIterator QgsAfsFeatureSource::getFeatures( const QgsFeatureRequest &re

QgsAfsSharedData *QgsAfsFeatureSource::sharedData() const
{
return mSharedData.data();
return mSharedData.get();
}

///////////////////////////////////////////////////////////////////////////////
Expand Down
6 changes: 3 additions & 3 deletions src/providers/arcgisrest/qgsafsfeatureiterator.h
Expand Up @@ -17,7 +17,7 @@

#include "qgsfeatureiterator.h"
#include "qgsafsshareddata.h"
#include <QSharedPointer>
#include <memory>

class QgsSpatialIndex;

Expand All @@ -26,12 +26,12 @@ class QgsAfsFeatureSource : public QgsAbstractFeatureSource
{

public:
QgsAfsFeatureSource( const QSharedPointer<QgsAfsSharedData> &sharedData );
QgsAfsFeatureSource( const std::shared_ptr<QgsAfsSharedData> &sharedData );
QgsFeatureIterator getFeatures( const QgsFeatureRequest &request ) override;
QgsAfsSharedData *sharedData() const;

protected:
QSharedPointer<QgsAfsSharedData> mSharedData;
std::shared_ptr<QgsAfsSharedData> mSharedData;

friend class QgsAfsFeatureIterator;
};
Expand Down
2 changes: 1 addition & 1 deletion src/providers/arcgisrest/qgsafsprovider.cpp
Expand Up @@ -34,7 +34,7 @@ QgsAfsProvider::QgsAfsProvider( const QString &uri )
, mValid( false )
, mObjectIdFieldIdx( -1 )
{
mSharedData = QSharedPointer<QgsAfsSharedData>( new QgsAfsSharedData() );
mSharedData.reset( new QgsAfsSharedData() );
mSharedData->mGeometryType = QgsWkbTypes::Unknown;
mSharedData->mDataSource = QgsDataSourceUri( uri );

Expand Down
4 changes: 2 additions & 2 deletions src/providers/arcgisrest/qgsafsprovider.h
Expand Up @@ -18,7 +18,7 @@
#ifndef QGSAFSPROVIDER_H
#define QGSAFSPROVIDER_H

#include <QSharedPointer>
#include <memory>
#include "qgsvectordataprovider.h"
#include "qgsdatasourceuri.h"
#include "qgsafsshareddata.h"
Expand Down Expand Up @@ -70,7 +70,7 @@ class QgsAfsProvider : public QgsVectorDataProvider

private:
bool mValid;
QSharedPointer<QgsAfsSharedData> mSharedData;
std::shared_ptr<QgsAfsSharedData> mSharedData;
int mObjectIdFieldIdx;
QString mLayerName;
QString mLayerDescription;
Expand Down
2 changes: 1 addition & 1 deletion src/providers/oracle/qgsoraclefeatureiterator.h
Expand Up @@ -50,7 +50,7 @@ class QgsOracleFeatureSource : public QgsAbstractFeatureSource
QString mQuery;
QgsCoordinateReferenceSystem mCrs;

QSharedPointer<QgsOracleSharedData> mShared;
std::shared_ptr<QgsOracleSharedData> mShared;

friend class QgsOracleFeatureIterator;
friend class QgsOracleExpressionCompiler;
Expand Down
4 changes: 2 additions & 2 deletions src/providers/oracle/qgsoracleprovider.cpp
Expand Up @@ -366,7 +366,7 @@ void QgsOracleProvider::appendPkParams( QgsFeatureId fid, QSqlQuery &qry ) const
}


QString QgsOracleUtils::whereClause( QgsFeatureId featureId, const QgsFields &fields, QgsOraclePrimaryKeyType primaryKeyType, const QList<int> &primaryKeyAttrs, QSharedPointer<QgsOracleSharedData> sharedData, QVariantList &args )
QString QgsOracleUtils::whereClause( QgsFeatureId featureId, const QgsFields &fields, QgsOraclePrimaryKeyType primaryKeyType, const QList<int> &primaryKeyAttrs, std::shared_ptr<QgsOracleSharedData> sharedData, QVariantList &args )
{
QString whereClause;

Expand Down Expand Up @@ -424,7 +424,7 @@ QString QgsOracleUtils::whereClause( QgsFeatureId featureId, const QgsFields &fi
return whereClause;
}

QString QgsOracleUtils::whereClause( QgsFeatureIds featureIds, const QgsFields &fields, QgsOraclePrimaryKeyType primaryKeyType, const QList<int> &primaryKeyAttrs, QSharedPointer<QgsOracleSharedData> sharedData, QVariantList &args )
QString QgsOracleUtils::whereClause( QgsFeatureIds featureIds, const QgsFields &fields, QgsOraclePrimaryKeyType primaryKeyType, const QList<int> &primaryKeyAttrs, std::shared_ptr<QgsOracleSharedData> sharedData, QVariantList &args )
{
QStringList whereClauses;
Q_FOREACH ( const QgsFeatureId featureId, featureIds )
Expand Down
6 changes: 3 additions & 3 deletions src/providers/oracle/qgsoracleprovider.h
Expand Up @@ -301,7 +301,7 @@ class QgsOracleProvider : public QgsVectorDataProvider
bool mHasSpatialIndex; //! Geometry column is indexed
QString mSpatialIndexName; //! name of spatial index of geometry column

QSharedPointer<QgsOracleSharedData> mShared;
std::shared_ptr<QgsOracleSharedData> mShared;

friend class QgsOracleFeatureIterator;
friend class QgsOracleFeatureSource;
Expand All @@ -316,14 +316,14 @@ class QgsOracleUtils
const QgsFields &fields,
QgsOraclePrimaryKeyType primaryKeyType,
const QList<int> &primaryKeyAttrs,
QSharedPointer<QgsOracleSharedData> sharedData,
std::shared_ptr<QgsOracleSharedData> sharedData,
QVariantList &params );

static QString whereClause( QgsFeatureIds featureIds,
const QgsFields &fields,
QgsOraclePrimaryKeyType primaryKeyType,
const QList<int> &primaryKeyAttrs,
QSharedPointer<QgsOracleSharedData> sharedData,
std::shared_ptr<QgsOracleSharedData> sharedData,
QVariantList &params );

static QString andWhereClauses( const QString &c1, const QString &c2 );
Expand Down

0 comments on commit b3da171

Please sign in to comment.