Constify

nyalldawson · nyalldawson · commit b3d5f277d973 · 2019-01-18T20:36:30.000+11:00
diff --git a/src/core/layertree/qgslayertreemodellegendnode.cpp b/src/core/layertree/qgslayertreemodellegendnode.cpp
@@ -92,7 +92,7 @@ QSizeF QgsLayerTreeModelLegendNode::drawSymbolText( const QgsLegendSettings &set
   double textHeight = settings.fontHeightCharacterMM( symbolLabelFont, QChar( '0' ) );
   double textDescent = settings.fontDescentMillimeters( symbolLabelFont );
 
-  QStringList lines = settings.splitStringForWrapping( data( Qt::DisplayRole ).toString() );
+  const QStringList lines = settings.splitStringForWrapping( data( Qt::DisplayRole ).toString() );
 
   labelSize.rheight() = lines.count() * textHeight + ( lines.count() - 1 ) * ( settings.lineSpacing() + textDescent );
 
@@ -111,7 +111,7 @@ QSizeF QgsLayerTreeModelLegendNode::drawSymbolText( const QgsLegendSettings &set
     labelY += textHeight;
   }
 
-  for ( QStringList::Iterator itemPart = lines.begin(); itemPart != lines.end(); ++itemPart )
+  for ( QStringList::ConstIterator itemPart = lines.constBegin(); itemPart != lines.constEnd(); ++itemPart )
   {
     labelSize.rwidth() = std::max( settings.textWidthMillimeters( symbolLabelFont, *itemPart ), double( labelSize.width() ) );
 

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,7 @@ QSizeF QgsLayerTreeModelLegendNode::drawSymbolText( const QgsLegendSettings &set`
`92`	`92`	`double textHeight = settings.fontHeightCharacterMM( symbolLabelFont, QChar( '0' ) );`
`93`	`93`	`double textDescent = settings.fontDescentMillimeters( symbolLabelFont );`
`94`	`94`
`95`		`- QStringList lines = settings.splitStringForWrapping( data( Qt::DisplayRole ).toString() );`
	`95`	`+ const QStringList lines = settings.splitStringForWrapping( data( Qt::DisplayRole ).toString() );`
`96`	`96`
`97`	`97`	`labelSize.rheight() = lines.count() * textHeight + ( lines.count() - 1 ) * ( settings.lineSpacing() + textDescent );`
`98`	`98`
`@@ -111,7 +111,7 @@ QSizeF QgsLayerTreeModelLegendNode::drawSymbolText( const QgsLegendSettings &set`
`111`	`111`	`labelY += textHeight;`
`112`	`112`	`}`
`113`	`113`
`114`		`- for ( QStringList::Iterator itemPart = lines.begin(); itemPart != lines.end(); ++itemPart )`
	`114`	`+ for ( QStringList::ConstIterator itemPart = lines.constBegin(); itemPart != lines.constEnd(); ++itemPart )`
`115`	`115`	`{`
`116`	`116`	`labelSize.rwidth() = std::max( settings.textWidthMillimeters( symbolLabelFont, *itemPart ), double( labelSize.width() ) );`
`117`	`117`