multi-layer identify:

- fix busy cursor - add progress bar - reduces CRS debugging noise git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@11580 c8812cc2-4d05-0410-92ff-de0c093fc19c
qgis · Sep 7, 2009 · b34c58c · b34c58c
1 parent b63e359
commit b34c58c
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 12 deletions.
diff --git a/src/app/qgsmaptoolidentify.cpp b/src/app/qgsmaptoolidentify.cpp
@@ -31,6 +31,7 @@
 #include "qgsvectorlayer.h"
 #include "qgsproject.h"
 #include "qgsmaplayerregistry.h"
+#include "qgisapp.h"
 
 #include <QSettings>
 #include <QMessageBox>
@@ -90,16 +91,26 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )
       return;
     }
 
+    QApplication::setOverrideCursor( Qt::WaitCursor );
+
     res = identifyLayer( layer, e->x(), e->y() );
+
+    QApplication::restoreOverrideCursor();
   }
   else
   {
+    connect( this, SIGNAL( identifyProgress( int, int ) ), QgisApp::instance(), SLOT( showProgress( int, int ) ) );
+
+    QApplication::setOverrideCursor( Qt::WaitCursor );
+
     QStringList noIdentifyLayerIdList = QgsProject::instance()->readListEntry( "Identify", "/disabledLayers" );
 
     for ( int i = 0; i < mCanvas->layerCount(); i++ )
     {
       QgsMapLayer *layer = mCanvas->layer( i );
 
+      emit identifyProgress( i, mCanvas->layerCount() );
+
       if ( noIdentifyLayerIdList.contains( layer->getLayerID() ) )
         continue;
 
@@ -110,6 +121,12 @@ void QgsMapToolIdentify::canvasReleaseEvent( QMouseEvent * e )
           break;
       }
     }
+
+    emit identifyProgress( mCanvas->layerCount(), mCanvas->layerCount() );
+
+    disconnect( this, SIGNAL( identifyProgress( int, int ) ), QgisApp::instance(), SLOT( showProgress( int, int ) ) );
+
+    QApplication::restoreOverrideCursor();
   }
 
   if ( res )
@@ -178,8 +195,6 @@ bool QgsMapToolIdentify::identifyVectorLayer( QgsVectorLayer *layer, int x, int
   calc.setEllipsoid( ellipsoid );
   calc.setSourceCrs( layer->srs().srsid() );
 
-  QApplication::setOverrideCursor( Qt::WaitCursor );
-
   QgsFeatureList featureList;
 
   // toLayerCoordinates will throw an exception for an 'invalid' point.
@@ -210,8 +225,6 @@ bool QgsMapToolIdentify::identifyVectorLayer( QgsVectorLayer *layer, int x, int
     QgsDebugMsg( QString( "Caught CRS exception %1" ).arg( cse.what() ) );
   }
 
-  QApplication::restoreOverrideCursor();
-
   QgsFeatureList::iterator f_it = featureList.begin();
 
   for ( ; f_it != featureList.end(); ++f_it )
@@ -282,8 +295,6 @@ bool QgsMapToolIdentify::identifyVectorLayer( QgsVectorLayer *layer, int x, int
 
   QgsDebugMsg( "Feature count on identify: " + QString::number( featureCount ) );
 
-  QApplication::restoreOverrideCursor();
-
   return featureCount > 0;
 }
 

diff --git a/src/app/qgsmaptoolidentify.h b/src/app/qgsmaptoolidentify.h
@@ -61,6 +61,9 @@ class QgsMapToolIdentify : public QgsMapTool
 
     virtual void deactivate();
 
+  signals:
+    void identifyProgress( int, int );
+
   private:
     bool identifyLayer( QgsMapLayer *layer, int x, int y );
     bool identifyRasterLayer( QgsRasterLayer *layer, int x, int y );

diff --git a/src/core/qgscoordinatereferencesystem.cpp b/src/core/qgscoordinatereferencesystem.cpp
@@ -682,7 +682,10 @@ void QgsCoordinateReferenceSystem::setProj4String( QString theProj4String )
   mCRS = OSRNewSpatialReference( NULL );
   mIsValidFlag = OSRImportFromProj4( mCRS, theProj4String.toLatin1().constData() ) == OGRERR_NONE;
   setMapUnits();
+
+#if defined(QGISDEBUG) && QGISDEBUG>=3
   debugPrint();
+#endif
 
   setlocale( LC_NUMERIC, oldlocale );
 }
@@ -756,7 +759,7 @@ void QgsCoordinateReferenceSystem::setMapUnits()
       QgsDebugMsg( "Unsupported map units of " + unit );
       mMapUnits = QGis::UnknownUnit;
     }
-    QgsDebugMsg( "Projection has angular units of " + unit );
+    QgsDebugMsgLevel( "Projection has angular units of " + unit, 3 );
   }
 }
 
@@ -882,11 +885,11 @@ bool QgsCoordinateReferenceSystem::operator==( const QgsCoordinateReferenceSyste
   {
     if ( OSRExportToWkt( theSrs.mCRS, &otherStr ) == OGRERR_NONE )
     {
-      QgsDebugMsg( QString( "Comparing " ) + thisStr );
-      QgsDebugMsg( QString( "     with " ) + otherStr );
+      QgsDebugMsgLevel( QString( "Comparing " ) + thisStr, 3 );
+      QgsDebugMsgLevel( QString( "     with " ) + otherStr, 3 );
       if ( !strcmp( thisStr, otherStr ) )
       {
-        QgsDebugMsg( QString( "MATCHED!" ) + otherStr );
+        QgsDebugMsgLevel( QString( "MATCHED!" ) + otherStr, 3 );
         CPLFree( thisStr );
         CPLFree( otherStr );
         return true;

diff --git a/src/core/qgsdistancearea.cpp b/src/core/qgsdistancearea.cpp
@@ -586,7 +586,7 @@ double QgsDistanceArea::computePolygonArea( const QList<QgsPoint>& points )
   double Qbar1, Qbar2;
   double area;
 
-  QgsDebugMsg( "Ellipsoid: " + mEllipsoid );
+  QgsDebugMsgLevel( "Ellipsoid: " + mEllipsoid, 3 );
   if (( ! mProjectionsEnabled ) || ( mEllipsoid == "NONE" ) )
   {
     return computePolygonFlatArea( points );

diff --git a/src/core/qgsscalecalculator.cpp b/src/core/qgsscalecalculator.cpp
@@ -47,7 +47,7 @@ void QgsScaleCalculator::setMapUnits( QGis::UnitType mapUnits )
 
 QGis::UnitType QgsScaleCalculator::mapUnits() const
 {
-  QgsDebugMsg( QString( "Map units returned as %1" ).arg( QString::number( mMapUnits ) ) );
+  QgsDebugMsgLevel( QString( "Map units returned as %1" ).arg( QString::number( mMapUnits ) ), 3 );
   return mMapUnits;
 }