[3d] Default shadows to first available directional light, instead

of forcing users to explicitly select this light after enabling shadows
qgis · Nov 4, 2020 · b335617 · b335617
1 parent 8b7fe31
commit b335617
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/src/3d/qgsshadowsettings.h b/src/3d/qgsshadowsettings.h
@@ -95,7 +95,7 @@ class _3D_EXPORT QgsShadowSettings
 
   private:
     bool mRenderShadows = false;
-    int mSelectedDirectionalLight = -1;
+    int mSelectedDirectionalLight = 0;
     double mMaximumShadowRenderingDistance = 500.0;
     double mShadowBias = 0.00001;
     int mShadowMapResolution = 2048;

diff --git a/src/app/3d/qgslightswidget.cpp b/src/app/3d/qgslightswidget.cpp
@@ -201,6 +201,7 @@ void QgsLightsWidget::onAddDirectionalLight()
   const QModelIndex newIndex = mLightsModel->addDirectionalLight( QgsDirectionalLightSettings() );
   mLightsListView->selectionModel()->select( newIndex, QItemSelectionModel::ClearAndSelect );
   emit lightsAdded();
+  emit directionalLightsCountChanged( mLightsModel->directionalLights().size() );
 }
 
 void QgsLightsWidget::onRemoveLight()

diff --git a/src/app/3d/qgsshadowrenderingsettingswidget.cpp b/src/app/3d/qgsshadowrenderingsettingswidget.cpp
@@ -56,7 +56,7 @@ void QgsShadowRenderingSettingsWidget::onDirectionalLightsCountChanged( int newC
   while ( usedDirectionalLightComboBox->count() > newCount )
     usedDirectionalLightComboBox->removeItem( usedDirectionalLightComboBox->count() - 1 );
   if ( previousItemIndex < 0 || previousItemIndex >= usedDirectionalLightComboBox->count() )
-    usedDirectionalLightComboBox->setCurrentIndex( -1 );
+    usedDirectionalLightComboBox->setCurrentIndex( 0 );
   else
     usedDirectionalLightComboBox->setCurrentIndex( previousItemIndex );
 }