More loop references

qgis · Aug 13, 2021 · b2933c6 · b2933c6
1 parent 52950b8
commit b2933c6
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 6 deletions.
diff --git a/src/app/qgsalignrasterdialog.cpp b/src/app/qgsalignrasterdialog.cpp
@@ -141,7 +141,7 @@ void QgsAlignRasterDialog::populateLayersView()
   QStandardItemModel *model = new QStandardItemModel();
   int i = 0;
   const auto constRasters = mAlign->rasters();
-  for ( const QgsAlignRaster::Item item : constRasters )
+  for ( const QgsAlignRaster::Item &item : constRasters )
   {
     QString layerName = _rasterLayerName( item.inputFilename );
 

diff --git a/src/server/services/wcs/qgswcsutils.cpp b/src/server/services/wcs/qgswcsutils.cpp
@@ -269,7 +269,8 @@ namespace QgsWcs
       QUrl url = request.originalUrl();
       QUrlQuery q( url );
 
-      for ( const auto param : q.queryItems() )
+      const QList<QPair<QString, QString> > queryItems = q.queryItems();
+      for ( const QPair<QString, QString> &param : queryItems )
       {
         if ( sFilter.contains( param.first.toUpper() ) )
           q.removeAllQueryItems( param.first );

diff --git a/src/server/services/wfs/qgswfsparameters.cpp b/src/server/services/wfs/qgswfsparameters.cpp
@@ -204,7 +204,8 @@ namespace QgsWfs
   void QgsWfsParameters::dump() const
   {
     log( "WFS Request parameters:" );
-    for ( const auto parameter : mWfsParameters.toStdMap() )
+    const auto map = mWfsParameters.toStdMap();
+    for ( const auto &parameter : map )
     {
       const QString value = parameter.second.toString();
 

diff --git a/src/server/services/wms/qgswmsutils.cpp b/src/server/services/wms/qgswmsutils.cpp
@@ -52,7 +52,8 @@ namespace QgsWms
       href = request.originalUrl();
       QUrlQuery q( href );
 
-      for ( const auto param : q.queryItems() )
+      const QList<QPair<QString, QString> > queryItems = q.queryItems();
+      for ( const QPair<QString, QString> &param : queryItems )
       {
         if ( sFilter.contains( param.first.toUpper() ) )
           q.removeAllQueryItems( param.first );

diff --git a/src/server/services/wmts/qgswmtsparameters.cpp b/src/server/services/wmts/qgswmtsparameters.cpp
@@ -154,7 +154,8 @@ namespace QgsWmts
   void QgsWmtsParameters::dump() const
   {
     log( "WMTS Request parameters:" );
-    for ( const auto parameter : mWmtsParameters.toStdMap() )
+    const auto map = mWmtsParameters.toStdMap();
+    for ( const auto &parameter : map )
     {
       const QString value = parameter.second.toString();
 

diff --git a/tests/src/core/testqgsziputils.cpp b/tests/src/core/testqgsziputils.cpp
@@ -162,7 +162,7 @@ void TestQgsZipUtils::genericTest( QString zipName, int expectedEntries, bool in
   QCOMPARE( files.count(), filesFromResultDir.count() );
 
   // Test if specific files are included in the root folder
-  for ( const QString fileName : testFileNames )
+  for ( const QString &fileName : testFileNames )
   {
     QVERIFY( filesFromResultDir.contains( unzipDirPath + fileName ) );
   }