fix bad use of getSelectedFeatures

qgis · Oct 28, 2019 · b23a972 · b23a972
1 parent ba00513
commit b23a972
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/gui/qgsrelationeditorwidget.cpp b/src/gui/qgsrelationeditorwidget.cpp
@@ -49,12 +49,9 @@ class QgsFilteredSelectionManager : public QgsVectorLayerSelectionManager
       : QgsVectorLayerSelectionManager( layer, parent )
       , mRequest( request )
     {
-      QgsFeature feature;
-      QgsFeatureIterator it = layer->getSelectedFeatures( mRequest );
-      while ( it.nextFeature( feature ) )
-      {
-        mSelectedFeatureIds << feature.id();
-      }
+      for ( auto fid : layer->selectedFeatureIds() )
+        if ( mRequest.acceptFeature( layer->getFeature( fid ) ) )
+          mSelectedFeatureIds << fid;
 
       connect( layer, &QgsVectorLayer::selectionChanged, this, &QgsFilteredSelectionManager::onSelectionChanged );
     }