Navigation Menu

Skip to content

Commit

Permalink
test_defwindowtitle.sh: also check Dialog
Browse files Browse the repository at this point in the history
  • Loading branch information
@jef-n
jef-n committed May 16, 2020
1 parent 47c1910 commit b1edb5e
Show file tree
Hide file tree
Showing 21 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion python/console/console_history_dlg.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<property name="leftMargin">
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/db_manager/ui/DlgCancelTaskQuery.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<widget class="QWidget" name="verticalLayoutWidget">
<property name="geometry">
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/ui/DlgMessage.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion python/plugins/processing/ui/DlgRenderingStyles.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<property name="spacing">
Expand Down
2 changes: 1 addition & 1 deletion python/pyplugin_installer/qgsplugindependenciesdialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/crashhandler/qgscrashdialog.ui
View file
Expand Up @@ -426,7 +426,7 @@
</palette>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<property name="styleSheet">
<string notr="true"/>
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/georeferencer/qgstransformtypedialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/offline_editing/offline_editing_progress_dialog_base.ui
View file
Expand Up @@ -14,7 +14,7 @@
<enum>Qt::NoContextMenu</enum>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/auth/qgsauthconfiguriedit.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/auth/qgsauthmethodplugins.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<property name="margin">
Expand Down
2 changes: 1 addition & 1 deletion src/ui/editorwidgets/qgsrelationreferenceconfigdlgbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QGridLayout" name="gridLayout_2">
<item row="4" column="0" colspan="2">
Expand Down
2 changes: 1 addition & 1 deletion src/ui/processing/qgsprocessingalgorithmdialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/processing/qgsprocessingalgorithmprogressdialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<property name="sizeGripEnabled">
<bool>true</bool>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsaddtaborgroupbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QFormLayout" name="formLayout">
<item row="0" column="0" colspan="2">
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsbrowserpropertiesdialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<property name="sizeGripEnabled">
<bool>true</bool>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsdatasourceselectdialog.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<property name="spacing">
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgserrordialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_2">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/qgsrelationmanagerdialogbase.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout">
<item>
Expand Down
2 changes: 1 addition & 1 deletion src/ui/symbollayer/widget_set_dd_value.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<item row="0" column="1">
Expand Down
4 changes: 2 additions & 2 deletions tests/code_layout/test_defwindowtitle.sh
View file
Expand Up @@ -2,9 +2,9 @@

# This test checks that dialogs have a non-default window title or it is not marked for translation

if git grep -B1 '<string>Form</string>' "*.ui" | grep -qs '<property name="windowTitle"'; then
if git grep -E -B1 '<string>(Form|Dialog)</string>' "*.ui" | grep -qs '<property name="windowTitle"'; then
echo ' *** Found ui with default window title - consider changing or unchecking "translatable"/adding notr="true"'
git grep -B1 '<string>Form</string>' "*.ui" | grep -A1 '<property name="windowTitle"'
git grep -E -B1 '<string>(Form|Dialog)</string>' "*.ui" | grep -A1 '<property name="windowTitle"'
exit 1
fi

2 changes: 1 addition & 1 deletion tests/testdata/qgis_local_server/layer_attribute_form.ui
View file
Expand Up @@ -11,7 +11,7 @@
</rect>
</property>
<property name="windowTitle">
<string>Dialog</string>
<string notr="true">Dialog</string>
</property>
<layout class="QGridLayout" name="gridLayout">
<item row="3" column="0">
Expand Down

0 comments on commit b1edb5e

Please sign in to comment.