Skip to content

Commit

Permalink
Use generic algorithm icon for qgis algorithms which do not
Browse files Browse the repository at this point in the history
have specific icons, instead of generic qgis icon

We consider these 'top level' algorithms, and using the
standard algorithm icon should help reflect this and
differentiate them from 3rd party algorithms.
  • Loading branch information
nyalldawson committed Jun 24, 2017
1 parent 8f586ef commit b1cadb1
Show file tree
Hide file tree
Showing 81 changed files with 0 additions and 494 deletions.
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/AddTableField.py
Expand Up @@ -51,12 +51,6 @@ class AddTableField(QgisAlgorithm):

TYPES = [QVariant.Int, QVariant.Double, QVariant.String]

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector table tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/AutoincrementalField.py
Expand Up @@ -51,12 +51,6 @@ def __init__(self):
self.addParameter(QgsProcessingParameterFeatureSink(self.OUTPUT, self.tr('Incremented')))
self.addOutput(QgsProcessingOutputVectorLayer(self.OUTPUT, self.tr('Incremented')))

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector table tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/BarPlot.py
Expand Up @@ -47,12 +47,6 @@ class BarPlot(QgisAlgorithm):
NAME_FIELD = 'NAME_FIELD'
VALUE_FIELD = 'VALUE_FIELD'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Graphics')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/BoxPlot.py
Expand Up @@ -47,12 +47,6 @@ class BoxPlot(QgisAlgorithm):
VALUE_FIELD = 'VALUE_FIELD'
MSD = 'MSD'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Graphics')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/ConcaveHull.py
Expand Up @@ -52,12 +52,6 @@ class ConcaveHull(QgisAlgorithm):
NO_MULTIGEOMETRY = 'NO_MULTIGEOMETRY'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/CreateAttributeIndex.py
Expand Up @@ -42,12 +42,6 @@ class CreateAttributeIndex(QgisAlgorithm):
FIELD = 'FIELD'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector general tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/CreateConstantRaster.py
Expand Up @@ -42,12 +42,6 @@ class CreateConstantRaster(QgisAlgorithm):
OUTPUT = 'OUTPUT'
NUMBER = 'NUMBER'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Raster tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/Datasources2Vrt.py
Expand Up @@ -48,12 +48,6 @@ class Datasources2Vrt(QgisAlgorithm):
VRT_FILE = 'VRT_FILE'
VRT_STRING = 'VRT_STRING'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector general tools')

Expand Down
9 changes: 0 additions & 9 deletions python/plugins/processing/algs/qgis/DefineProjection.py
Expand Up @@ -47,15 +47,6 @@ class DefineProjection(QgisAlgorithm):
CRS = 'CRS'
OUTPUT = 'OUTPUT'

#def getIcon(self):
# return QIcon(os.path.join(pluginPath, 'images', 'ftools', 'basic_statistics.png'))

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector general tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/DeleteColumn.py
Expand Up @@ -41,12 +41,6 @@ class DeleteColumn(QgisAlgorithm):
COLUMNS = 'COLUMN'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('drop,delete,remove,fields,columns,attributes').split(',')

Expand Down
Expand Up @@ -39,12 +39,6 @@ class DeleteDuplicateGeometries(QgisAlgorithm):
INPUT = 'INPUT'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector general tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/DeleteHoles.py
Expand Up @@ -41,12 +41,6 @@ class DeleteHoles(QgisAlgorithm):
MIN_AREA = 'MIN_AREA'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('remove,delete,drop,holes,rings,fill').split(',')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/DensifyGeometries.py
Expand Up @@ -45,12 +45,6 @@ class DensifyGeometries(QgisAlgorithm):
VERTICES = 'VERTICES'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('add,vertices,points').split(',')

Expand Down
Expand Up @@ -46,12 +46,6 @@ class DensifyGeometriesInterval(QgisAlgorithm):
INTERVAL = 'INTERVAL'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/DropGeometry.py
Expand Up @@ -42,12 +42,6 @@ class DropGeometry(QgisAlgorithm):
INPUT_LAYER = 'INPUT_LAYER'
OUTPUT_TABLE = 'OUTPUT_TABLE'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('remove,drop,delete,geometry,objects').split(',')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/EquivalentNumField.py
Expand Up @@ -43,12 +43,6 @@ class EquivalentNumField(QgisAlgorithm):
OUTPUT = 'OUTPUT'
FIELD = 'FIELD'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector table tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/ExecuteSQL.py
Expand Up @@ -56,12 +56,6 @@ class ExecuteSQL(QgisAlgorithm):
INPUT_GEOMETRY_CRS = 'INPUT_GEOMETRY_CRS'
OUTPUT_LAYER = 'OUTPUT_LAYER'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector general tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/Explode.py
Expand Up @@ -43,12 +43,6 @@ class Explode(QgisAlgorithm):
INPUT = 'INPUT'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/ExtendLines.py
Expand Up @@ -42,12 +42,6 @@ class ExtendLines(QgisAlgorithm):
START_DISTANCE = 'START_DISTANCE'
END_DISTANCE = 'END_DISTANCE'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/ExtractByLocation.py
Expand Up @@ -45,12 +45,6 @@ class ExtractByLocation(QgisAlgorithm):
PRECISION = 'PRECISION'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('extract,filter,location,intersects,contains,within').split(',')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/ExtractSpecificNodes.py
Expand Up @@ -48,12 +48,6 @@ class ExtractSpecificNodes(QgisAlgorithm):
OUTPUT_LAYER = 'OUTPUT_LAYER'
NODES = 'NODES'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/FieldPyculator.py
Expand Up @@ -57,12 +57,6 @@ class FieldsPyculator(QgisAlgorithm):

TYPES = [QVariant.Int, QVariant.Double, QVariant.String]

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector table tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/FieldsCalculator.py
Expand Up @@ -61,12 +61,6 @@ class FieldsCalculator(QgisAlgorithm):

TYPES = [QVariant.Double, QVariant.Int, QVariant.String, QVariant.Date]

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector table tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/FieldsMapper.py
Expand Up @@ -54,12 +54,6 @@ def __init__(self):
GeoAlgorithm.__init__(self)
self.mapping = None

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector table tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/FindProjection.py
Expand Up @@ -52,12 +52,6 @@ class FindProjection(QgisAlgorithm):
TARGET_AREA_CRS = 'TARGET_AREA_CRS'
OUTPUT_HTML_FILE = 'OUTPUT_HTML_FILE'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('crs,srs,coordinate,reference,system,guess,estimate,finder,determine').split(',')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/FixGeometry.py
Expand Up @@ -44,12 +44,6 @@ class FixGeometry(QgisAlgorithm):
INPUT = 'INPUT'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def tags(self):
return self.tr('repair,invalid,geometry').split(',')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/GeometryByExpression.py
Expand Up @@ -49,12 +49,6 @@ class GeometryByExpression(QgisAlgorithm):
WITH_M = 'WITH_M'
EXPRESSION = 'EXPRESSION'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/GeometryConvert.py
Expand Up @@ -43,12 +43,6 @@ class GeometryConvert(QgisAlgorithm):
TYPE = 'TYPE'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector geometry tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/Gridify.py
Expand Up @@ -46,12 +46,6 @@ class Gridify(QgisAlgorithm):
VSPACING = 'VSPACING'
OUTPUT = 'OUTPUT'

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector general tools')

Expand Down
6 changes: 0 additions & 6 deletions python/plugins/processing/algs/qgis/HubDistanceLines.py
Expand Up @@ -63,12 +63,6 @@ class HubDistanceLines(QgisAlgorithm):
'Layer units'
]

def icon(self):
return QgsApplication.getThemeIcon("/providerQgis.svg")

def svgIconPath(self):
return QgsApplication.iconPath("providerQgis.svg")

def group(self):
return self.tr('Vector analysis tools')

Expand Down

3 comments on commit b1cadb1

@nirvn
Copy link
Contributor

@nirvn nirvn commented on b1cadb1 Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a vector icon here?

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be already - the generic alg icon is svg

@nirvn
Copy link
Contributor

@nirvn nirvn commented on b1cadb1 Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nyalldawson , it doesn't show as vector in models.

Please sign in to comment.